New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608800 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 608805



Sign in to add a comment

gpu/ipc/service tests should not depend on gpu/ipc/client

Project Member Reported by markdittmer@chromium.org, May 3 2016

Issue description

Fix for service-side gpu_memory_buffer tests (https://codereview.chromium.org/1908013002/) accesses SurfaceTextureManager and InProcessSurfaceTextureManager, both in client-side code.

This seems like a client/service separation violation.
 
Blockedon: 608805
Cc: fsam...@chromium.org
Owner: tguilbert@chromium.org
Status: Started (was: Untriaged)
SurfaceTextureManager is no longer used. I will be sending out a CL that removes it shortly.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e776235561780d5548259663ba62bf8bf550c6a

commit 3e776235561780d5548259663ba62bf8bf550c6a
Author: tguilbert <tguilbert@chromium.org>
Date: Fri Dec 02 19:25:21 2016

Remove SurfaceTextureManager

This CL is a continuation of the cleanup started by
reveman@ in c0329013d5cacd4c6c135e9d130a66ac3e25db4a

The SurfaceTexture implementation of the GpuMemoryBuffer
was the only client of the SurfaceTextureManager.

BUG= 608800 ,
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2525483005
Cr-Commit-Position: refs/heads/master@{#435991}

[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/app/android/child_process_service_impl.cc
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/browser/BUILD.gn
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/content/browser/android/browser_surface_texture_manager.cc
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/content/browser/android/browser_surface_texture_manager.h
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/browser/android/child_process_launcher_android.cc
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/browser/android/child_process_launcher_android.h
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/content/test/content_test_suite.cc
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/command_buffer/common/unittest_main.cc
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/ipc/client/BUILD.gn
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/gpu/ipc/client/android/in_process_surface_texture_manager.cc
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/gpu/ipc/client/android/in_process_surface_texture_manager.h
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/ipc/common/BUILD.gn
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/gpu/ipc/common/android/surface_texture_manager.cc
[delete] https://crrev.com/b1aa5026d5af3a6a325cb7be6c0cdafdce3a9a04/gpu/ipc/common/android/surface_texture_manager.h
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/ipc/common/gpu_surface_tracker.h
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/3e776235561780d5548259663ba62bf8bf550c6a/gpu/ipc/service/gpu_memory_buffer_factory_test_template.h

Status: Fixed (was: Started)

Sign in to add a comment