New issue
Advanced search Search tips

Issue 608787 link

Starred by 1 user
Status: Fixed
Owner:
eranm@chromium.org
Closed: May 2016
Cc:
certific...@googlegroups.com
rsleevi@chromium.org
eranm@chromium.org
asymmetric@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Certificate Transparency: UMA is not logged for Pilot's STH age

Project Member Reported by eranm@chromium.org, May 3 2016 
In sth_distributor.cc there's code to emit, via UMA, the age of Pilot's STH as observed by clients:
https://code.google.com/p/chromium/codesearch#chromium/src/net/cert/sth_distributor.cc&sq=package:chromium&l=29&q=sth_distributor

However nothing is emitted.

The problem is that the comparison with kPilotLogID is incorrect, so the condition for emitting UMA is never met.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96

commit 2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96
Author: eranm <eranm@chromium.org>
Date: Wed May 04 11:22:44 2016

Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG= 608787 

Review-Url: https://codereview.chromium.org/1950463002
Cr-Commit-Position: refs/heads/master@{#391480}

[modify] https://crrev.com/2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96/net/cert/sth_distributor.cc

Comment 2 by eranm@chromium.org, May 4 2016

Labels: Merge-Request-51 M-51
Requesting a merge of this small fix to M51. I believe it is a very low risk as it only affects gathering UMA (and not having it means we will not collect data until M52).

Comment 3 by sshru...@google.com, May 5 2016

Labels: OS-All

Comment 4 by tin...@google.com, May 5 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 by gov...@chromium.org, May 6 2016 

Please merge your change to M51 branch 2704 by 5:00 PM PST Monday(05/09) so we can take it for next week beta release.Thank you.
Project Member

Comment 6 by sheriffbot@chromium.org, May 8 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381067e58d5ec3cb1ffb1cec42422ebc0b605524

commit 381067e58d5ec3cb1ffb1cec42422ebc0b605524
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Mon May 09 09:57:45 2016

Certificate Transparency: Fix Pilot log ID comparison.

Only 32 bytes of the Log ID should be compared, not the trailing null.

BUG= 608787 

Review-Url: https://codereview.chromium.org/1950463002
Cr-Commit-Position: refs/heads/master@{#391480}
(cherry picked from commit 2ed9e868847dcc8ab0b60ed22a87d6a8fc56cf96)

R=eranm@chromium.org

Review URL: https://codereview.chromium.org/1958083002 .

Cr-Commit-Position: refs/branch-heads/2704@{#443}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/381067e58d5ec3cb1ffb1cec42422ebc0b605524/net/cert/sth_distributor.cc

Comment 8 by eranm@chromium.org, May 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment