[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.

Just checking on the status of this.  We have progress porting code over and testing it, but we need a build target that builds the 0.6 Blimp APK so we can start running the app code we're building.

Tommy can you point Shakti in the right direction or give him another contact that could help him work through this?  Thanks!

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Figure out how to get builds from bots.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/76b169a0c01ae4dd925eef94abac89744664b69a

commit 76b169a0c01ae4dd925eef94abac89744664b69a
Author: Alex Mineer <amineer@chromium.org>
Date: Fri Jul 22 20:09:53 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/bf697be3bd4137efc551ff9edbc9f9e4228fd2c6

commit bf697be3bd4137efc551ff9edbc9f9e4228fd2c6
Author: Alex Mineer <amineer@chromium.org>
Date: Fri Jul 22 21:06:11 2016

We should be able to investigate whether the blimp build has core enabled or not with:

$ unzip ./out/Release/ChromeCloud.apk classes.dex
$ ./third_party/android_tools/sdk/build-tools/23.0.1/dexdump classes.dex | grep -e 'Class descriptor.*org/chromium/blimp/core'


For a dummy build (enable_blimp = false) it should show something like:
  Class descriptor  : 'Lorg/chromium/blimp/core/DummyBlimpClientContext;'

For an actual build (enable_blimp = true) it should show something like:
  Class descriptor  : 'Lorg/chromium/blimp/core/BlimpClientContextImpl;'
  Class descriptor  : 'Lorg/chromium/blimp/core/contents/BlimpContentsFactory;'
  Class descriptor  : 'Lorg/chromium/blimp/core/contents/BlimpContentsImpl;'
  Class descriptor  : 'Lorg/chromium/blimp/core/contents/BlimpContentsObserverProxy;'
  Class descriptor  : 'Lorg/chromium/blimp/core/contents/BlimpNavigationControllerImpl;'

[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce

commit 7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce
Author: nyquist <nyquist@chromium.org>
Date: Tue Jul 26 23:08:49 2016

Rename GN arg for enabling blimp.

Since the enable_blimp flag was only ever supposed to be used for
the blimp client, this makes that abundandtly clear by renaming
the GN arg itself.

BUG= 611094 ,624025, 608765 

Review-Url: https://codereview.chromium.org/2179843005
Cr-Commit-Position: refs/heads/master@{#407956}

[modify] https://crrev.com/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce/blimp/client/core/BUILD.gn
[modify] https://crrev.com/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce/blimp/client/public/BUILD.gn
[modify] https://crrev.com/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce/build/args/blimp_client.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179e0366187c3062f487fe55629872185fb5fb4a

commit 179e0366187c3062f487fe55629872185fb5fb4a
Author: nyquist <nyquist@chromium.org>
Date: Tue Aug 09 02:24:13 2016

Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG= 608765 

Review-Url: https://codereview.chromium.org/2225233002
Cr-Commit-Position: refs/heads/master@{#410532}

[modify] https://crrev.com/179e0366187c3062f487fe55629872185fb5fb4a/blimp/client/core/BUILD.gn
[add] https://crrev.com/179e0366187c3062f487fe55629872185fb5fb4a/blimp/client/core/config.gni

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dded60e5b00fbd24162c0aed8ced4951270d6498

commit dded60e5b00fbd24162c0aed8ced4951270d6498
Author: Alex Mineer <amineer@chromium.org>
Date: Tue Aug 09 15:52:11 2016

Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG= 608765 

(cherry picked from commit 179e0366187c3062f487fe55629872185fb5fb4a)

Review-Url: https://codereview.chromium.org/2225233002
Cr-Original-Commit-Position: refs/heads/master@{#410532}
Cr-Commit-Position: refs/branch-heads/2823@{#6}
Cr-Branched-From: c6b7050c321314686730fb679a7122341f16c7c2-refs/heads/master@{#410278}

[modify] https://crrev.com/dded60e5b00fbd24162c0aed8ced4951270d6498/blimp/client/core/BUILD.gn
[add] https://crrev.com/dded60e5b00fbd24162c0aed8ced4951270d6498/blimp/client/core/config.gni

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf

commit f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf
Author: Alex Mineer <amineer@chromium.org>
Date: Tue Aug 09 17:46:52 2016

Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG= 608765 

Review-Url: https://codereview.chromium.org/2225233002
Cr-Commit-Position: refs/heads/master@{#410532}
(cherry picked from commit 179e0366187c3062f487fe55629872185fb5fb4a)

Review URL: https://codereview.chromium.org/2223423004 .

Cr-Commit-Position: refs/branch-heads/2824@{#3}
Cr-Branched-From: facabd3224aecbcab4bea9daadad31c67488d78c-refs/heads/master@{#410520}

[modify] https://crrev.com/f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf/blimp/client/core/BUILD.gn
[add] https://crrev.com/f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf/blimp/client/core/config.gni

Required changes have all landed on trunk and things appear to be working; we should have an integrated Blimp APK with every official build.  Marking this as fixed, but please re-open if there was more you wanted to do as a part of this, nyquist@.