New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608759 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Traveling - Back 2/6
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 597756
issue 599621



Sign in to add a comment

design and implement blimp tab

Project Member Reported by klo...@chromium.org, May 3 2016

Issue description

As a key component for 0.6, we need to implement Blimp as a Clank tab. See details here
https://docs.google.com/document/d/1hO_1HBbixwiu2iSyrCTYwisGAtCnE6Smpc3N7iD4n04/edit#heading=h.z6ne0og04bp5

 
Blocking: 597756
Labels: Blimp-M53-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Labels: -M-54 M-55
Moving to M-55.  We probably need a bit more work to make sure Tab works properly with Blimp.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516883acd2ca500fb7174d105124d356878ddccb

commit 516883acd2ca500fb7174d105124d356878ddccb
Author: nyquist <nyquist@chromium.org>
Date: Wed Aug 31 21:28:14 2016

Add BlimpView to a Chrome tab when Blimp is enabled.

This CL creates a BlimpView that is owned by the native
BlimpContentsViewAndroid. It is created whenever the
BlimpContentsViewAndroid is created, which is done when
BlimpContentsImpl is created.

The BlimpView needs access to the current Android Context, which
is now passed through the call to CreateBlimpContents() as a
NativeWindow which on Android is a WindowAndroid.

When a BlimpContents is available and Blimp is enabled, this also
hooks up the BlimpView to TabContentViewParent.

The BlimpView is with this patch attached to the view hierarchy,
and sends onSizeChanged events to the BlimpContentsImpl. The
touch events are piped through to the BlimpCompositorManager.

The old BlimpView in //blimp/client/app was colliding with the new,
so it has been moved in to the namespace blimp::client:app.

BUG= 608759 

Review-Url: https://codereview.chromium.org/2270323004
Cr-Commit-Position: refs/heads/master@{#415760}

[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/BUILD.gn
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/app/android/blimp_app_jni_registrar.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/app/android/javatests/src/org/chromium/blimp/core/MockBlimpClientContext.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/BUILD.gn
[add] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/DEPS
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/blimp_contents_impl_android.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc
[add] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/blimp_view.cc
[add] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/blimp_view.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java
[add] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpView.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_manager.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_manager.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_view_android.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/contents/blimp_contents_view_android.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/dummy_blimp_client_context.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/core/dummy_blimp_client_context.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/public/BUILD.gn
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/test/BUILD.gn
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/test/DEPS
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/blimp/test/run_all_unittests.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/chrome/browser/android/tab_android.h
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/ui/android/resources/resource_manager_impl_unittest.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/ui/android/window_android.cc
[modify] https://crrev.com/516883acd2ca500fb7174d105124d356878ddccb/ui/android/window_android.h

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment