Issue metadata
Sign in to add a comment
|
10.2%-72.5% regression in blink_perf.parser at 390873:390896 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 3 2016
=== Auto-CCing suspected CL author markdittmer@chromium.org === Hi markdittmer@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Migrate content/common/gpu/media code to media/gpu Author : markdittmer Commit description: This is part of a gpu & media refactor to enable proper layering for Mus. See bug for details. BUG= 586386 Review-Url: https://codereview.chromium.org/1882373004 Cr-Commit-Position: refs/heads/master@{#390896} Commit : 6e70beb84fe0d0a3d27e4369c8b6aaae001afb81 Date : Mon May 02 05:42:15 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@390894 162.25 4.13771 12 good chromium@390895 158.115 4.75728 8 good chromium@390896 167.964 5.00192 18 bad <-- Bisect job ran on: mac_10_11_perf_bisect Bug ID: 608726 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser Test Metric: query-selector-all-attribute-complex/query-selector-all-attribute-complex Relative Change: 3.00% Score: 99.5 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/607 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013674939049481264 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5847988052688896 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 3 2016
I kicked off a second bisect at https://chromeperf.appspot.com/buildbucket_job_status/9013660875094138464
,
May 3 2016
Commit range linked from graph (https://chromium.googlesource.com/chromium/src/+log/2aaedda2430ecad19a8ac4427c145d1b093f3df9%5E..6e70beb84fe0d0a3d27e4369c8b6aaae001afb81?pretty=fuller) suggests that one of the other commits in the range is the culprit. My CL had nothing to with Blink, whereas several others are all third_party/WebKit.
,
May 3 2016
+yosin@ Report [1] shows commit-range-of-2 (my and yosin's CLs) [2]. Based on the comments and files touched I suspect that the latter caused the regression. [1] https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglMuutgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1MiMtwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglM-FvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglMGgpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglKuIsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglK_oqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1Ly7ugoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglKucqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1LrduQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1PzApwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglKv6uQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1PzUtgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1Pr-ogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1MivqQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1Pz3qAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1PqlswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglPqFqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglPrjuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1LT5tQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1Ki4uAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1LT5tQsM [2] https://chromium.googlesource.com/chromium/src/+log/95d6f1792e11fefa919d81d1ed7c0d233deafa76%5E..6e70beb84fe0d0a3d27e4369c8b6aaae001afb81?pretty=fuller
,
May 4 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : binding: Makes Window/Location's attributes accessor-type properties. Author : yukishiino Commit description: Makes almost all the attributes (except for cross-origin accessible attributes) accessor-type properties. The target attributes in this CL are DOM attributes of Window, Location and workers not annotated as [DoNotCheckSecurity], which are cross-origin accessible. BUG= 43394 , 516274 Review-Url: https://codereview.chromium.org/1380503002 Cr-Commit-Position: refs/heads/master@{#390893} Commit : 9ac1750adf85027985c7af3468e0b972c2086235 Date : Mon May 02 05:05:22 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@390872 418.583 13.6328 5 good chromium@390884 418.32 10.9912 5 good chromium@390890 398.62 22.4722 5 good chromium@390892 404.789 13.0821 5 good chromium@390893 123.342 5.0159 5 bad <-- chromium@390896 119.505 4.48524 5 bad Bisect job ran on: android_nexus5_perf_bisect Bug ID: 608726 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser Test Metric: query-selector-first/query-selector-first Relative Change: 71.45% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3650 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013660875094138464 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5290350839595008 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 4 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : binding: Makes Window/Location's attributes accessor-type properties. Author : yukishiino Commit description: Makes almost all the attributes (except for cross-origin accessible attributes) accessor-type properties. The target attributes in this CL are DOM attributes of Window, Location and workers not annotated as [DoNotCheckSecurity], which are cross-origin accessible. BUG= 43394 , 516274 Review-Url: https://codereview.chromium.org/1380503002 Cr-Commit-Position: refs/heads/master@{#390893} Commit : 9ac1750adf85027985c7af3468e0b972c2086235 Date : Mon May 02 05:05:22 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@390872 426.923 8.91557 5 good chromium@390884 439.721 2.93799 5 good chromium@390890 424.203 6.95013 5 good chromium@390892 423.558 9.95558 5 good chromium@390893 124.993 3.41509 5 bad <-- chromium@390896 124.826 6.72629 5 bad Bisect job ran on: android_nexus5_perf_bisect Bug ID: 608726 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser Test Metric: query-selector-first/query-selector-first Relative Change: 70.76% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3651 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013659593817969040 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5810937919963136 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lanwei@google.com
, May 3 2016