New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608722 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Xoogler
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 608721



Sign in to add a comment

Tracing V2: try out proto JS decoders for TraceViewer

Project Member Reported by primiano@chromium.org, May 3 2016

Issue description

Background context: bit.ly/TracingV2 
Once we have some prototypes of proto-based trace, we can write the auto-generated JS stubs for TraceViewer and see how they work.
What we want to asses here is:

1. Do they work.
2. How fast are they compared to the current JSON.
3. How many events can we load before OOM-ing compared to the current JSON?


In the meantime you want to start getting familiar with proto3 JS generation.

 
Cc: -petrcermak@chromium.org
Cc: -petrcermak@chromium.org
Blocking: -608719
Labels: -Pri-2 Pri-3
Status: Assigned (was: Untriaged)
Components: Internals>Instrumentation>Memory
Status: Archived (was: Assigned)
1. I've tried official JS protobuf implementation https://github.com/google/protobuf but it's complex to be integrated with TraceViewer primarly because of 'goog' imports in the library.

2. Realised that writing simple protobuf decoder is not that hard in JS. Bacause for purposes of Tracing V2 we gonna need to parse relatively small messages into JSON structures. It can be achieved by very simple message descriptors to be generated by protoc plugin. As an example I wrote trivial proof-of-concept https://github.com/gkraynov/open_source_snippets/tree/master/protobuf_javascript_trivial_decoder

I think own implementation could be integrated with TraceViewer at lower cost and with better fit to the purpose.

3. Archiving the issue for this time because Tracing V2 is currently suspended, but somehow answering this question was important for planning.

Sign in to add a comment