New issue
Advanced search Search tips

Issue 608720 link

Starred by 1 user
Status: WontFix
Owner:
alexilin@chromium.org
Closed: Sep 12
Cc:
jkarlin@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 629382



Sign in to add a comment

Fix preconnect UMA

Project Member Reported by csharrison@chromium.org, May 3 2016 
The current UMA as implemented for speculative preconnect does not work,
and the code paths used to thread information about whether the socket was created speculatively are never called.

This should be fixed in a general sort of way, as the loading team is planning on using preconnect for a few more use cases.

Comment 1 by csharrison@chromium.org, Aug 2 2016

Blocking: 629382
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ec9584645140a656781aece14912e728fefb8f

commit 65ec9584645140a656781aece14912e728fefb8f
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Mon Oct 02 14:50:31 2017

net: Thread request motivation into preconnect sockets

This patch changess the way how a socket motivation is set for
preconnected sockets. It passes a motivation through
PreconnectSocketsForHttpRequests() and InitSocketPoolHelper() to the
ClientSocketBaseHelper class that sets the right motivation after the
ConnectJob is completed.

This patch doesn't fix the problem that all secure sockets are marked as
was_used_to_convey_data because they've transmitted data to establish a
secure connection.

Bug:  608720 
Change-Id: Ibba4c638456c4805a4d00bc778de48da9a9e9704
Reviewed-on: https://chromium-review.googlesource.com/667111
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505609}
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/http/http_proxy_client_socket_pool.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool_base.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/client_socket_pool_manager.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/socks_client_socket_pool.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/socks_client_socket_pool.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/ssl_client_socket_pool.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/stream_socket.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/transport_client_socket_pool.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/transport_client_socket_pool.h
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/websocket_transport_client_socket_pool.cc
[modify] https://crrev.com/65ec9584645140a656781aece14912e728fefb8f/net/socket/websocket_transport_client_socket_pool.h

Comment 3 by csharrison@chromium.org, Jan 23 2018

Owner: alexilin@chromium.org

Comment 4 by alexilin@chromium.org, Sep 12

Status: WontFix (was: Started)
Net.PreconnectUtilization2 histogram was removed.
►

Sign in to add a comment