New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608718 link

Starred by 1 user
Status: Duplicate
Merged: issue 608114
Owner: ----
Closed: May 2016
Cc:
█ fsam...@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content_common erroneously depending on WebKit/public:blink (beyond WebKit/public:blink_minimal)

Project Member Reported by markdittmer@chromium.org, May 3 2016 
Encountered the following build error:

ninja: Entering directory `out/Debug'
[2/147] LINK ./nacl_helper
FAILED: nacl_helper 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread -m64 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -Wl,-rpath-link=../Debug -Wl,--disable-new-dtags -Wl,--export-dynamic -o "./nacl_helper" -Wl,--start-group @"./nacl_helper.rsp"  -Wl,--end-group  -ldl -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lpangocairo-1.0 -lpango-1.0 -lcairo -lfontconfig -lfreetype -lexpat -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lXrandr -lXss -lgconf-2 -lresolv -lgio-2.0 -lasound -lm -lz -ldbus-1 -latk-1.0 
../../content/common/child_process_sandbox_support_impl_linux.cc:69: error: undefined reference to 'blink::WebFontRenderStyle::setDefaults()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

In attempting to fix it, I tried making //content/common dep on //third_party/WebKit/public:blink, but found that this is forbidden:

FAILED: build.ninja 
/usr/local/google/home/markdittmer/src/chromium/src/buildtools/linux64/gn --root=/usr/local/google/home/markdittmer/src/chromium/src -q gen //out/Debug/
ERROR at //chrome/BUILD.gn:452:1: assert_no_deps failed.
group("browser_dependencies") {
^------------------------------
//chrome:browser_dependencies has an assert_no_deps entry:
  //third_party/WebKit/public:blink
which fails for the dependency path:
  //chrome:browser_dependencies ->
  //chrome/browser:browser ->
  //content/public/browser:browser ->
  //content/public/browser:browser_sources ->
  //content/browser:browser ->
  //content/common:common ->
  //third_party/WebKit/public:blink
ninja: error: rebuilding 'build.ninja': subcommand failed

Not sure how the dep on blink::WebFontRenderStyle was introduced, and/or whether it was moved out of blink_minimal. It's possible that https://bugs.chromium.org/p/chromium/issues/detail?id=608715 is caused by the same as-yet-unidentified change.

Comment 1 by markdittmer@chromium.org, May 3 2016

Cc: scottmg@chromium.org
Could this be how the issue was introduced? https://chromium.googlesource.com/chromium/src/+/ffb95be04fb4effb750884083cb1c166c5499b7a%5E%21/chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index d805bff..3109d77 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -474,9 +474,7 @@
       # build this is OK because all of content is linked into one library.
       # Note that the blink_headers target is OK, so we can't do a wildcard for
       # all blink targets.
-      # TODO(brettw)  bug 582206 : Blink should not be linked into the browser
-      # process, and then we can enable this.
-      #"//third_party/WebKit/public:blink",
+      "//third_party/WebKit/public:blink",
       # TODO(brettw)  bug 581766 : V8 should not be linked into the browser
       # process, and then we can enable this.
       #"//v8/*",

Comment 2 by scottmg@chromium.org, May 3 2016

Mergedinto: 608114
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment