New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608713 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: May 2016
Cc:
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 584266



Sign in to add a comment

Improve snippet ordering for incoming snippets

Project Member Reported by nepper@chromium.org, May 3 2016 
The current snippet ordering is documented in  Issue 601736 . Since we get scores (relevance and popularity) already today, we will adjust the ordering of incoming snippets:

Most-recently retrieved snippets {
[Highest score snippet]
.
.
.
[Lowest score snippet]
}
Previosuly retrieved snippets {
[Highest score snippet]
.
.
.
[Lowest score snippet]

}

Comment 1 by jkrcal@chromium.org, May 9 2016

Labels: zine-mr-iter-14 zine-mr-iter-13
Status: Started (was: Assigned)
Almost done, hope to land it early this week (iter 14).

Comment 2 by fi...@chromium.org, May 10 2016

Blocking: 584266
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a244f68391a327cde16a006150f862ae641aab

commit 33a244f68391a327cde16a006150f862ae641aab
Author: jkrcal <jkrcal@chromium.org>
Date: Wed May 11 09:28:37 2016

Allow fetching personalized snippets from ChromeReader.

This amounts to:
 - adding singin_manager and token_service to the fetcher;
 - adding a variation parameter to determine the type of fetching (see bug 606320);
 - changes to the request strings sent to ChromeReader;
 - getting the snippets ordered by their score (see  bug 608713 );

Additionally, this CL adds a score member to NTPSnippet and exposes it in snippets-internals.
(Loading and storing of NTPSnippet needed to be changed a bit as the score entry is stored in the top level suggestion node and not in the contentInfo subnode as everything else that we loaded so far).

BUG= 603907 ,  608713 , 606320
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1922083004
Cr-Commit-Position: refs/heads/master@{#392886}

[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets.gypi
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/DEPS
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippet.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippet.h
[add] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_constants.cc
[add] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_constants.h
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_service_unittest.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

Comment 4 by jkrcal@chromium.org, May 11 2016

Status: Fixed (was: Started)

Comment 5 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 6 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp

Comment 7 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP
►

Sign in to add a comment