New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608697 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 255



Sign in to add a comment

Regression: Mid click does not work in chrome://apps page.

Project Member Reported by bj00129...@techmahindra.com, May 3 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2723.0 Safari/537.36

Steps to reproduce the problem:
1. Launch chrome and navigate to chrome://apps.
2. Mid click on any app and observe.

What is the expected behavior?
Upon mid click on the app, it should get opened in the new tab.

What went wrong?
Instead apps not getting opened.

WebStore page: 

Did this work before? Yes 

Chrome version: 52.0.2723.0  Channel: dev
OS Version: 52.0.2723.0
Flash Version: Shockwave Flash 22.0 r0

This is a regression issue broken in M52.
G:52.0.2718.0
B:52.0.2719.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/66bea1de4dbc4a18684655979360031c14ad97a9..501509013f808ee9d45431b4c181233087a2ec44

Suspected change: https://chromium.googlesource.com/chromium/src/+/76fea00a18f75886ea649414393228180306e13d
 
Expected.ogv
506 KB Download
Actual.ogv
687 KB Download
Labels: ReleaseBlock-Beta M-52 OS-Mac OS-Windows
Owner: nzolghadr@chromium.org
Status: Assigned (was: Unconfirmed)
Issue is reproducible on the latest canary(52.0.2723.0) on Mac OS 10.11.4,Win 7 and Ubuntu 14.04.

Comment 2 by ajha@chromium.org, May 3 2016

Cc: kavvaru@chromium.org ajha@chromium.org durga.behera@chromium.org
Labels: -Type-Bug -Pri-2 hasbisect Pri-1 Type-Bug-Regression
Cc: dtapu...@chromium.org rbyers@chromium.org
I don't think reverting the change for not sending middle click event is the right approach. We are now just following the spec in Chrome. Is this something that can be fixed in chrome://apps page?
Components: UI>Browser>NewTabPage
Since this app is doing an explicit check for the middle button on the other side of the chrome.send('launchApp'...) is it not possible to track the mouse down and see if the mouse up target is the same and then do this action there?

This  is the first report of something we've seen that is explicitly testing for middle button click and doing something explicitly (as opposed to something unexpectedly as we were trying to address in removing the click on the non-primary buttons as per the spec)

Can someone from the NTP weigh in on this?
Able to see this issue on windows 7 using chrome latest version 52.0.2730.0.
could any one please look into this issue.

Thanks,

Status: Started (was: Assigned)
I have started looking at this and uploaded a patch. I just forgot to update the status here. Sorry about that.

Comment 7 by rbyers@chromium.org, May 12 2016

Blockedon: 255
Cc: nyerramilli@chromium.org
just to update, able to reproduce the issue on Win7, Mac OSX 10.11.4, Ubuntu 14.04 using Chrome Canary #52.0.239.0
Thanks for the update. Hope the fix will be available soon as we are planning to promote M52 to Beta to during the last week of May.
Cc: dbeam@chromium.org
I'm hoping the same. dbeam@ is reviewing the change.
Still able to reproduce the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 52.0.2743.3.
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88eb1110baafcba070e750866a343e81b6bcc524

commit 88eb1110baafcba070e750866a343e81b6bcc524
Author: nzolghadr <nzolghadr@chromium.org>
Date: Tue May 24 21:55:53 2016

Dispatch middle click manually by tracking mouse

Tracking targets for middle button mousedown event
and fire click event for it on mouse up if necessary.

Note: The click is not finding the common parent of
mousedown and up targets for simplicty and only sends
the click to the target if both down and up happened
on the same node.

BUG= 608697 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1963823002
Cr-Commit-Position: refs/heads/master@{#395707}

[modify] https://crrev.com/88eb1110baafcba070e750866a343e81b6bcc524/chrome/browser/resources/ntp4/new_tab.html
[add] https://crrev.com/88eb1110baafcba070e750866a343e81b6bcc524/chrome/browser/resources/ntp4/synthetic_middleclick.js

Status: Fixed (was: Started)
This change just landed. Let me know if you see this problem again.
Labels: Merge-Request-52
Status: Started (was: Fixed)

Comment 15 by tin...@google.com, May 27 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Labels: TE-Verified-M53 TE-Verified-53.0.2751.0
Tested this issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest canary M53-53.0.2751.0 and observed middle clicking on the app page is able to open it in a new tab as expected. Hence adding TE-Verified label.
MouseMiddleClick.mp4
686 KB Download
Project Member

Comment 17 by bugdroid1@chromium.org, May 30 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d43781be25ba16cb8a8be67a64a32d6991bb53d

commit 4d43781be25ba16cb8a8be67a64a32d6991bb53d
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon May 30 15:55:42 2016

Dispatch middle click manually by tracking mouse

Tracking targets for middle button mousedown event
and fire click event for it on mouse up if necessary.

Note: The click is not finding the common parent of
mousedown and up targets for simplicty and only sends
the click to the target if both down and up happened
on the same node.

BUG= 608697 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1963823002
Cr-Commit-Position: refs/heads/master@{#395707}
(cherry picked from commit 88eb1110baafcba070e750866a343e81b6bcc524)

Review URL: https://codereview.chromium.org/2027453002 .

Cr-Commit-Position: refs/branch-heads/2743@{#126}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/4d43781be25ba16cb8a8be67a64a32d6991bb53d/chrome/browser/resources/ntp4/new_tab.html
[add] https://crrev.com/4d43781be25ba16cb8a8be67a64a32d6991bb53d/chrome/browser/resources/ntp4/synthetic_middleclick.js

Status: Fixed (was: Started)
Merged in 52.
Labels: TE-Verified-M52 TE-Verified-52.0.2743.19
Verified the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest Dev M52-52.0.2743.19 and observed the fix is working fine as expected on M52 as well. Hence adding TE-Verified label.
Labels: Hotlist-Input-Dev

Comment 21 Deleted

The "click" event is no longer dispatched for non-primary buttons as per UI events spec. This will ensure the pages that don't check the buttons attribute on their click handlers don't show unexpected behaviors when middle clicking for example.
Instead there will be new event "auxclick" event for non-primary buttons that will be useful for some apps that truly care about click action for non-primary buttons. For example in case someone wants to prevent opening a new tab when middle clicking a link or adobt any other actions on click behavior of any non-primary button. Here is the spec for the event and some examples:
https://navidz.github.io/auxclick/
Labels: auxclick

Sign in to add a comment