New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608690 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Computed style node up-to-date for custom properties

Reported by r...@opera.com, May 3 2016

Issue description

Querying custom properties from getComputedStyle().getPropertyValue() does not recalculate computed style when necessary.

Works in Gecko.

 
variables.html
394 bytes View Download

Comment 1 by r...@opera.com, May 3 2016

Cc: shans@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4bf5e78fabe368cf4005dcb4b3adc19107afab5

commit b4bf5e78fabe368cf4005dcb4b3adc19107afab5
Author: rune <rune@opera.com>
Date: Tue May 03 21:58:16 2016

Make sure computed style is up-to-date for custom properties.

For custom properties, we didn't call updateLayoutTreeForNode which
meant the computed style object might return out-of-date values for
custom properties.

Did some cleanup in getPropertyCSSValue for known properties.

R=shans@chromium.org
BUG= 608690 

Review-Url: https://codereview.chromium.org/1945623002
Cr-Commit-Position: refs/heads/master@{#391368}

[modify] https://crrev.com/b4bf5e78fabe368cf4005dcb4b3adc19107afab5/third_party/WebKit/LayoutTests/fast/css/variables/computed-style.html
[modify] https://crrev.com/b4bf5e78fabe368cf4005dcb4b3adc19107afab5/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Comment 3 by r...@opera.com, May 3 2016

Status: Fixed (was: Started)

Sign in to add a comment