Issue metadata
Sign in to add a comment
|
Regression: Bookmark bubble does not close through keyboard.
Reported by
vvishwak...@etouch.net,
May 3 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2723.0 (Official Build) 5e216d9b62275101c30f4a5cb2174bb68970ef3c-refs/heads/master@{#391139} (32/64-bit) OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1) Launch chrome, open NTP, press Alt key(focus is on wrench) and then press Shift+Tab key (focus is on bookmark button). 2) Press Spacebar (bookmark bubble opens) and then press Tab key till focus is on Done button. 3) Now press Enter key and observe. Bookmark bubble does not close on pressing Enter key. Bookmark bubble should close on pressing Enter key. This is a Regression issue broken in M-52, below is the bisect info Manual bisect: Good build: 52.0.2715.0 Bad build: 52.0.2716.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/67d8ccb45177b214dbdb51375f1ed1ba31ffa07b..c7c0d3ab719b356d8ccef636506507b2cead7ff1?pretty=fuller&n=100 Suspecting: r389406 Note: Issue is not seen on Linux and Mac OS.
,
May 4 2016
Marking the above issue as RB-Stable as this is a recent regression. Feel free to change accordingly. Thank you!
,
May 4 2016
This affects m51. I suppose we could/should merge. However I don't think it's a release blocker, it's just a minor annoyance that affects a minority of users. +pkasting in case he feels differently, but I'm just going to mark this fixed and close it.
,
May 4 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-51; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-51 label, otherwise remove Merge-TBD label. Thanks.
,
May 4 2016
I think the patch here is simple/safe enough that this is worth merging to M-51. Setting Merge-Request flag to see if branch owners agree.
,
May 5 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47e2c11e1f821683bc96acca9fe0f608f8a4aa14 commit 47e2c11e1f821683bc96acca9fe0f608f8a4aa14 Author: Evan Stade <estade@chromium.org> Date: Thu May 05 14:44:17 2016 Second try at fixing location bar icon keyboard activation. Space activates on up, enter activates on down. BUG= 608645 Review-Url: https://codereview.chromium.org/1947533003 Cr-Commit-Position: refs/heads/master@{#391451} (cherry picked from commit b98dddabd0ed3058a834d759e067800891c00501) Review URL: https://codereview.chromium.org/1955583002 . Cr-Commit-Position: refs/branch-heads/2704@{#383} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/bubble_icon_view.h [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/47e2c11e1f821683bc96acca9fe0f608f8a4aa14/chrome/browser/ui/views/location_bar/location_icon_view.h
,
May 9 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 4 2016