New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608644 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.3%-18.8% regression in webrtc_perf_tests at 12592:12592

Project Member Reported by ivoc@chromium.org, May 3 2016

Issue description

See graphs below.
 

Comment 1 by ivoc@chromium.org, May 3 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=608644

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglK3QowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICglPrArwoM


Bot(s) for this bug's original alert(s):

webrtc-mac-large-tests

Comment 2 by ivoc@chromium.org, May 3 2016

Cc: ivoc@chromium.org
 Issue 608643  has been merged into this issue.

Comment 3 by ivoc@chromium.org, May 3 2016

Labels: -M-50 M-52
Owner: minyue@chromium.org
Minyue, it looks like your CL (https://codereview.webrtc.org/1901633002) is causing a regression in several NetEQ perf stats. Could you have a look at it?

Comment 4 by ivoc@chromium.org, May 3 2016

Cc: hlundin@chromium.org
Problem is found. The reason is that the performance of sync buffer in NetEq is affected by its length. A quick fix is at hand. It may not get the value down to what it was, though.

Comment 6 by ivoc@chromium.org, May 4 2016

The graphs confirm that the values dropped to a lower level. Do we need to look into this any further, or do you think we can close the issue?
We can keep this bug open. I can try to drag it down a bit more.
Perf sheriff ping - looks like we're making progress here though.

Comment 9 by minyue@chromium.org, May 10 2016

We may likely see a significant improvements in the following days, when this takes its effect 

https://codereview.webrtc.org/1948483002/
Status: Fixed (was: Assigned)
look good so far. I think we can close this issue.
Nice. So most bots actually show an improvement comparing with the original code. Good work!

Comment 12 by ivoc@chromium.org, May 11 2016

Nice work Minyue!

Sign in to add a comment