Issue metadata
Sign in to add a comment
|
15.3%-18.8% regression in webrtc_perf_tests at 12592:12592 |
||||||||||||||||||||
Issue descriptionSee graphs below.
,
May 3 2016
,
May 3 2016
Minyue, it looks like your CL (https://codereview.webrtc.org/1901633002) is causing a regression in several NetEQ perf stats. Could you have a look at it?
,
May 3 2016
,
May 3 2016
Problem is found. The reason is that the performance of sync buffer in NetEq is affected by its length. A quick fix is at hand. It may not get the value down to what it was, though.
,
May 4 2016
The graphs confirm that the values dropped to a lower level. Do we need to look into this any further, or do you think we can close the issue?
,
May 4 2016
We can keep this bug open. I can try to drag it down a bit more.
,
May 10 2016
Perf sheriff ping - looks like we're making progress here though.
,
May 10 2016
We may likely see a significant improvements in the following days, when this takes its effect https://codereview.webrtc.org/1948483002/
,
May 11 2016
look good so far. I think we can close this issue.
,
May 11 2016
Nice. So most bots actually show an improvement comparing with the original code. Good work!
,
May 11 2016
Nice work Minyue! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ivoc@chromium.org
, May 3 2016