New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608618 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus effect is not seen on 'CANCEL' button on editing a search engine in md-settings page.

Project Member Reported by radhakri...@techmahindra.com, May 3 2016 
Chrome Version       : 52.0.2723.0 (Official Build)
OS Version : Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and open "chrome://md-settings/".
(2)Click on 'Basic' >> 'Search engine' >> Manage Search engines.
(3)Edit any search engine and traverse the focus by hitting tab until focus reaches to 'CANCEL' button and observe.

What is the expected result?
The letters on the button should turn bold to indicate the presence of focus.

What happens instead?
No effect is seen on the button even though the focus is on it.

This is a regression issue as it is working fine on 50.0.2661.75 (Official Build) beta, will provide other info soon.
Actual.mp4
972 KB Download
expected.mp4
1.1 MB Download

Comment 1 by radhakri...@techmahindra.com, May 3 2016

Labels: Proj-MaterialDesign-WebUI hasbisect
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 51.0.2667.0
Bad Build : 51.0.2668.0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/3c7592464a581a96d3c92015c1ee3b878205880b..33407f13bfd05bc2614fd063bcbc6ad38904ad24

Suspecting https://codereview.chromium.org/1758973002 from changelog.

@dpapad: Please look into the issue.

Comment 2 by ajha@chromium.org, May 3 2016

Labels: OS-Mac
Reproducible on the latest canary(52.0.2723.0) on Mac OS 10.11.4 as well.

Comment 3 by ajha@chromium.org, May 3 2016

Labels: -M-52 M-51

Comment 4 by dpa...@chromium.org, May 3 2016

Status: Started (was: Assigned)

Comment 5 by dbeam@chromium.org, May 3 2016

Labels: -Pri-1 -M-51 Pri-2
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d

commit 33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d
Author: dpapad <dpapad@chromium.org>
Date: Wed May 04 23:29:50 2016

MD Settings: <settings-dialog>, restore focus effect for the cancel button.

BUG= 608618 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1951503002
Cr-Commit-Position: refs/heads/master@{#391688}

[modify] https://crrev.com/33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d/chrome/browser/resources/settings/settings_dialog.html
[modify] https://crrev.com/33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d/chrome/browser/resources/settings/settings_shared_css.html

Comment 7 by dpa...@chromium.org, May 5 2016

Status: Fixed (was: Started)
►

Sign in to add a comment