New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608615 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: May 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird highlight for search field is seen in dev tools.

Reported by rk...@etouch.net, May 3 2016 
Chrome Version: 52.0.2723.0 Revision 5e216d9b62275101c30f4a5cb2174bb68970ef3c-refs/heads/master@{#391139}
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and press Esc key
(2) Open Search section, click anywhere in console section and observe the highlight on search field

Weird  highlight for search field is seen.

No such highlight should seen on search field.

This is  a regression issue, broken in 'M-52', below is bisect info:

Good Build: 52.0.2722.0
Bad Build: 52.0.2723.0

Narrow Bisect :
https://chromium.googlesource.com/chromium/src/+log/3e3742c09818d4453ee0b18e01bb958eb5b9658e..f0eb5cc52b1f14db73d58d1248213fe40131857e?pretty=fuller&n=100

Suspecting: r391033

Note: Issue is not seen on Mac OS, Will soon update the Linux info.
Actual_screenshot.png
23.2 KB View Download

Comment 1 by l...@chromium.org, May 3 2016 

Unable to exactly reproduce the screenshot provided.  On Windows 7 using 52.0.2723.0, what I saw was an outline slightly thinner on the bottom (see weirdsearch.png).  This is my fault when I added an overflow: hidden rule.  It should be easily fixable with new margins.


@rkote, since I can't exactly reproduce your screenshot, can you try this:
- open the search field in DevTools
- open DevTools in DevTools (either right click in DevTools > Inspect, or do Ctrl+shift+I)
- Inspect the original search input field
- using the 2nd DevTools, under the style group ".search-drawer-header input.search-config-search", change the margin rule to "margin: 1px".

After that, focusing the search field should behave as expected.  Please let me know if you can try it out.  If it works, I can make a CL with the updated style.
weirdsearch.png
8.6 KB View Download
proposed change.png
67.9 KB View Download

Comment 2 by rk...@etouch.net, May 4 2016 

With respect to comment 1:

Unable to perform above mentioned test case mentioned in comment 1, as unable to open devtools inside devtools  [i.e. "open DevTools in DevTools (either right click in DevTools > Inspect, or do Ctrl+shift+I)"]

Note: For reproducing above issue take new user and follow the steps which is mentioned in original bug. kindly refer the attached screencast for the same.
Actual_highlight.mp4
737 KB Download

Comment 3 by l...@chromium.org, May 4 2016

Status: Started (was: Assigned)
Thank you for the screencast!  I'm able to reproduce on Linux.  A CL is on the way.
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7584daee96f12ce4339821e393ce15fd45cc422e

commit 7584daee96f12ce4339821e393ce15fd45cc422e
Author: luoe <luoe@chromium.org>
Date: Wed May 04 23:43:51 2016

DevTools: fix styles in full text search input

BUG= 608615 

Review-Url: https://codereview.chromium.org/1945293003
Cr-Commit-Position: refs/heads/master@{#391695}

[modify] https://crrev.com/7584daee96f12ce4339821e393ce15fd45cc422e/third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css

Comment 5 by l...@chromium.org, May 4 2016

Status: Fixed (was: Started)
Changes committed.  Please review if needed.
►

Sign in to add a comment