New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608598 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

other settings-animated-pages hide when another section is opened and fade out when the section is closed

Project Member Reported by michae...@chromium.org, May 3 2016

Issue description

version: 52.0.2722.0 

1. At chrome://md-settings open a sub-page, e.g. Manage Search Engines

Expected: the section expands, hiding the other sections behind it
Actual: the section expands, but also, the other sections which are settings-animated-pages (have sub-pages) disappear

2. Go back

Expected: other sections don't change, they're simply hidden behind the expanded section
Actual: other sections fade out, then instantly become opaque again
 
Owner: michae...@chromium.org
Status: Started (was: Available)
There are multiple issues in the animations, so I'll do some investigating and come up with a plan.
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55deb67c516167728a79cc29c7a00771c7c1b9c

commit f55deb67c516167728a79cc29c7a00771c7c1b9c
Author: michaelpg <michaelpg@chromium.org>
Date: Mon May 09 23:51:26 2016

MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG= 610429 , 608598 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1965553002
Cr-Commit-Position: refs/heads/master@{#392480}

[modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page.css
[modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page/main_page_behavior.html
[modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Labels: Hotlist-MD-Settings-Navigation
Status: Fixed (was: Started)
Cc: kavvaru@chromium.org durga.behera@chromium.org ajha@chromium.org
 Issue 608253  has been merged into this issue.

Sign in to add a comment