GVD DCHECKs on webview |
||||||
Issue description05-02 21:05:20.397 5803 5906 F chromium: [FATAL:gpu_video_decoder.cc(297)] Check failed: !init_cb_.is_null(). Looks like the problem is that AVDA is returning SUPPORTS_DEFERRED_INITIALIZATION only when deferred backing strategy is enabled. But it then always does deferred initialization when the client supports it. i.e., there seems to be no need for the SUPPORTS_DEFERRED_INITIALIZATION capability.
,
May 3 2016
Silly me. I've been in Android land so long I forgot other VDAs existed.. AVDA returning SUPPORTS unconditionally makes sense to me. I'll do that.
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37452ef6ad139284e11392a6bd7062ab1f18f43f commit 37452ef6ad139284e11392a6bd7062ab1f18f43f Author: watk <watk@chromium.org> Date: Wed May 04 18:33:58 2016 media: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION Previously AVDA was only reporting this capability when deferred rendering was enabled, but they are orthogonal. BUG= 608581 Review-Url: https://codereview.chromium.org/1944963002 Cr-Commit-Position: refs/heads/master@{#391576} [modify] https://crrev.com/37452ef6ad139284e11392a6bd7062ab1f18f43f/media/gpu/android_video_decode_accelerator.cc
,
May 4 2016
Needed for M-51 on a1 devices?
,
May 4 2016
Good call. I believe so
,
May 4 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0ff7a3b6f6a314f57b31e5ac68f5ae0b2e30a9e commit f0ff7a3b6f6a314f57b31e5ac68f5ae0b2e30a9e Author: Chris Watkins <watk@chromium.org> Date: Wed May 04 22:38:18 2016 media: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION Previously AVDA was only reporting this capability when deferred rendering was enabled, but they are orthogonal. BUG= 608581 Review-Url: https://codereview.chromium.org/1944963002 Cr-Commit-Position: refs/heads/master@{#391576} (cherry picked from commit 37452ef6ad139284e11392a6bd7062ab1f18f43f) Review URL: https://codereview.chromium.org/1952053002 . Cr-Commit-Position: refs/branch-heads/2704@{#378} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f0ff7a3b6f6a314f57b31e5ac68f5ae0b2e30a9e/content/common/gpu/media/android_video_decode_accelerator.cc
,
May 4 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by liber...@chromium.org
, May 3 2016hrm, good point. either AVDA::Capabilities should set SUPPORTS_ unconditionally, or Initialize needs to be smarter (AVDA::DoesSupportDeferredInitialization() { return UseDeferred();}?) > there seems to be no need for the SUPPORTS_DEFERRED_INITIALIZATION capability. we still need the SUPPORTS_... flag for other vdas, though.