[Media Router WebUI] Focus sometimes jumps on sink list after switching back from search view. |
|||||
Issue descriptionVersion: 52.0.2722.0 1. Open MR dialog; assume multiple sinks. 2. Switch to search/filter view. 3. Press tab, then arrow down through list and focus on a sink. 4. Press ESC to exit search/filter view. Same sink should be focused on the sink view. 5. Press arrow up or down. <-- up/down arrow keys is the expected way to navigate paper-menus, not tab. Sometimes, the focus jumps to a random sink (e.g. 5 sinks below), not the one directly above/below the currently focused sink.
,
May 12 2016
,
May 12 2016
,
Jun 23 2016
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b20972c25ec11167e6cb77bf81a1573ea930d96a commit b20972c25ec11167e6cb77bf81a1573ea930d96a Author: takumif <takumif@chromium.org> Date: Wed Jun 29 17:56:34 2016 Fix the bug where focus jumps around on the media router sink list The bug occurs when you are navigating the MR dialog on your keyboard. When you search for a sink, focus on it using tab/arrow keys, and return to the sink list with esc, the same sink ostensibly remains in focus, but when you press up or down, the focus jumps to an unexpected place because the focus had not been recognized on the Polymer side. This CL fixes that by calling selectIndex, a Polymer paper-menu method for changing the focus. This CL also modifies a MR container filter test to check that the appropriate sink not only remains in focus but also stays as the selected item in the Polymer logic. BUG= 608578 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2096733002 Cr-Commit-Position: refs/heads/master@{#402866} [modify] https://crrev.com/b20972c25ec11167e6cb77bf81a1573ea930d96a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/b20972c25ec11167e6cb77bf81a1573ea930d96a/chrome/browser/resources/media_router/externs.js [modify] https://crrev.com/b20972c25ec11167e6cb77bf81a1573ea930d96a/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
,
Jun 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by apaci...@chromium.org
, May 3 2016Owner: btolsch@chromium.org
Status: Assigned