See, e.g.: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak?numbuilds=200 The first failure seems to be in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19169 from 2016-04-29. I'm not sure of the cause, but there are several CLs related to OOPIFs that might be suspicious. @lukasza, can you take a look?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942152eebd1d44b6b774f2b3a766dea55108f10d commit 942152eebd1d44b6b774f2b3a766dea55108f10d Author: dpranke <dpranke@chromium.org> Date: Tue May 03 02:19:35 2016 Mark link-crossorigin-stylesheet-no-cors as flaky on WebKit Linux Leak. TBR=lukasza@chromium.org BUG= 608577 Review-Url: https://codereview.chromium.org/1935393002 Cr-Commit-Position: refs/heads/master@{#391156} [modify] https://crrev.com/942152eebd1d44b6b774f2b3a766dea55108f10d/third_party/WebKit/LayoutTests/LeakExpectations
Repro: $ ninja -C out/gn ... blink_tests $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --no-retry-failures --additional-expectations=third_party/WebKit/LayoutTests/LeakExpectations --enable-leak-detection --iterations=20 http/tests/security/link-crossorigin-stylesheet-no-cors.html
I've bisected the flakiness down to https://crrev.com/1819593002 (Preload scan external css for @import).
Looks like the problem is that preloads are not expected to have clients added to them so early. See: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp&l=231 +hiroshige@, japhet@, mkwst@ I was nervous about this when I landed the patch. Maybe we need some notion of a WeakResourceClient? Let me know what you think. I'm fine reverting this patch if I can't figure out an easy solution to this problem.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ac78e618532b15d8d26af86808f1028f4d62242 commit 3ac78e618532b15d8d26af86808f1028f4d62242 Author: csharrison <csharrison@chromium.org> Date: Wed May 04 14:47:20 2016 Manual revert of "Preload scan external css for @import" This reverts commit c3698d693def17f7f4c2d17f462de63ee06fe10d. https://codereview.chromium.org/1819593002 It was causing some crashes / layout test flakiness TBR=kinuko@chromium.org,kouhei@chromium.org BUG= 608577 ,608310 Review-Url: https://codereview.chromium.org/1947053002 Cr-Commit-Position: refs/heads/master@{#391506} [delete] https://crrev.com/455dbe71939225cb3765da12c6aed749b72276ea/third_party/WebKit/LayoutTests/http/tests/preload/external_css_import_preload.html [delete] https://crrev.com/455dbe71939225cb3765da12c6aed749b72276ea/third_party/WebKit/LayoutTests/http/tests/resources/css_with_import.css [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h [modify] https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33272b2b3bc8266e51b02926212c7188f79975fc commit 33272b2b3bc8266e51b02926212c7188f79975fc Author: csharrison <csharrison@chromium.org> Date: Fri May 06 18:15:34 2016 Revert "Mark link-crossorigin-stylesheet-no-cors as flaky on WebKit Linux Leak." This reverts commit 942152eebd1d44b6b774f2b3a766dea55108f10d. This flakiness should be fixed by reverting the offending CL: https://codereview.chromium.org/1819593002 TBR=lukasza@chromium.org,dpranke@chromium.org BUG= 608577 Review-Url: https://codereview.chromium.org/1960643003 Cr-Commit-Position: refs/heads/master@{#392099} [modify] https://crrev.com/33272b2b3bc8266e51b02926212c7188f79975fc/third_party/WebKit/LayoutTests/LeakExpectations
Going to mark this as fixed. I'll make sure to flake-test this when I get around to relanding the @import scanning change.
Comment 1 by dpranke@chromium.org
, May 3 2016