Mac nit: Fullscreen overlay has some subpixel gunk on it |
||||||
Issue descriptionChrome Version : 52.0.2722.0 OS Version: OS X 10.11.4 What steps will reproduce the problem? 1. Go fullscreen at https://permission.site on a non-retina screen. 2. Zoom in to the "Press Esc to exit fullscreen" overlay What is the expected result? No gunk What happens instead of that? There's some black gunk around the fonts. Also there's subpixel AA when there shouldn't be. I suspect its related. views::Label sets RenderText::set_subpixel_rendering_suppressed(true), but this is ignored with RenderTextMac
,
May 3 2016
https://codereview.chromium.org/1941293002
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63254c155cad73e88e113887f2646603f96986f8 commit 63254c155cad73e88e113887f2646603f96986f8 Author: tapted <tapted@chromium.org> Date: Wed May 04 05:37:13 2016 RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() RenderTextMac currently doesn't invoke SetFontRenderParams which means parameters such as RenderText::subpixel_rendering_suppressed() do not propagate. BUG= 608575 Review-Url: https://codereview.chromium.org/1941293002 Cr-Commit-Position: refs/heads/master@{#391452} [modify] https://crrev.com/63254c155cad73e88e113887f2646603f96986f8/ui/gfx/render_text_harfbuzz.h [modify] https://crrev.com/63254c155cad73e88e113887f2646603f96986f8/ui/gfx/render_text_mac.mm [modify] https://crrev.com/63254c155cad73e88e113887f2646603f96986f8/ui/gfx/render_text_unittest.cc
,
May 4 2016
,
May 6 2016
Verified in Canary 52.0.2725.0 Requesting a merge to M51, since we are all approved to roll the new UI to stable there on Mac (launch bug: Issue 585009). Also I suspect this behind the less-subtle, but more elusive, Issue 604092 .
,
May 6 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdac52255fe138f03da71919824f7a606b1ab2fe commit bdac52255fe138f03da71919824f7a606b1ab2fe Author: Trent Apted <tapted@chromium.org> Date: Fri May 06 01:00:18 2016 [merge-m51] RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() RenderTextMac currently doesn't invoke SetFontRenderParams which means parameters such as RenderText::subpixel_rendering_suppressed() do not propagate. BUG= 608575 Review-Url: https://codereview.chromium.org/1941293002 Cr-Commit-Position: refs/heads/master@{#391452} (cherry picked from commit 63254c155cad73e88e113887f2646603f96986f8) Review URL: https://codereview.chromium.org/1947283005 . Cr-Commit-Position: refs/branch-heads/2704@{#408} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/bdac52255fe138f03da71919824f7a606b1ab2fe/ui/gfx/render_text_harfbuzz.h [modify] https://crrev.com/bdac52255fe138f03da71919824f7a606b1ab2fe/ui/gfx/render_text_mac.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tapted@chromium.org
, May 3 20161.6 KB
1.6 KB View Download