New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608564 link

Starred by 1 user
Status: Verified
Owner:
█ jww@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
a...@google.com
█ mmi...@gmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 336894



Sign in to add a comment

Suborigins incorrectly throw exception when localStorage and sessionStorage are accessed

Project Member Reported by jww@chromium.org, May 3 2016 
As pointed out in comment 30 of  issue 336894 , localStorage and sessionStorage incorrectly throw exceptions when they're accessed. This is not spec compliant and is definitely problematic for sites adopting Suborigins. We should probably give Suborigins their own storage objects.

Comment 1 by jww@chromium.org, May 3 2016

Blocking: 336894

Comment 2 by jww@chromium.org, Jun 8 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142972d9a3a304b276727f5167a06920587bf582

commit 142972d9a3a304b276727f5167a06920587bf582
Author: jww <jww@chromium.org>
Date: Thu Oct 06 05:59:41 2016

Re-enable storage for Suborigins.

Suborigins should, according to the spec, have access to their own
storage partitions. This CL re-enables the storage objects for
suborigins. Additionally, it implements the Cookies Tree Model updates
to make sure that the storage partitions appear under their parent
host's storage object.

BUG= 608564 ,  336894 

Review-Url: https://codereview.chromium.org/2005783005
Cr-Commit-Position: refs/heads/master@{#423446}

[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/browser/dom_storage/dom_storage_context_impl.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/common/origin_util.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/common/origin_util_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/public/common/origin_util.h
[add] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/access-storage.php
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-storage-dom-access.php
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

Comment 4 by jww@chromium.org, Oct 6 2016

Status: Verified (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142972d9a3a304b276727f5167a06920587bf582

commit 142972d9a3a304b276727f5167a06920587bf582
Author: jww <jww@chromium.org>
Date: Thu Oct 06 05:59:41 2016

Re-enable storage for Suborigins.

Suborigins should, according to the spec, have access to their own
storage partitions. This CL re-enables the storage objects for
suborigins. Additionally, it implements the Cookies Tree Model updates
to make sure that the storage partitions appear under their parent
host's storage object.

BUG= 608564 ,  336894 

Review-Url: https://codereview.chromium.org/2005783005
Cr-Commit-Position: refs/heads/master@{#423446}

[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/browsing_data_local_storage_helper_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/browser/dom_storage/dom_storage_context_impl.h
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/common/origin_util.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/common/origin_util_unittest.cc
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/content/public/common/origin_util.h
[add] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/LayoutTests/http/tests/security/suborigins/resources/access-storage.php
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-storage-dom-access.php
[modify] https://crrev.com/142972d9a3a304b276727f5167a06920587bf582/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

Comment 6 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment