New issue
Advanced search Search tips

Issue 608541 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 661623



Sign in to add a comment

key_systems_config_selector_unittest fails on Android

Project Member Reported by w...@chromium.org, May 2 2016

Issue description

Note: you can't run media_blink_unittests on android until this CL lands http://crrev.com/1938263002

C   39.545s Main  [FAIL] KeySystemConfigSelectorTest.VideoCapabilities_AllSupported:
C   39.545s Main  [ RUN      ] KeySystemConfigSelectorTest.VideoCapabilities_AllSupported
C   39.545s Main  [ERROR:key_systems.cc(558)] supported is not a known system
C   39.545s Main  [ERROR:key_systems.cc(558)] supported is not a known system
C   39.546s Main  ../../media/blink/key_system_config_selector_unittest.cc:575: Failure
C   39.546s Main  Value of: config_.videoCapabilities.size()
C   39.546s Main    Actual: 1
C   39.546s Main  Expected: 2u
C   39.546s Main  Which is: 2
C   39.546s Main  [  FAILED  ] KeySystemConfigSelectorTest.VideoCapabilities_AllSupported (5 ms)
C   39.546s Main  [FAIL] KeySystemConfigSelectorTest.VideoCapabilities_Codecs_AllSupported:
C   39.546s Main  [ RUN      ] KeySystemConfigSelectorTest.VideoCapabilities_Codecs_AllSupported
C   39.546s Main  [ERROR:key_systems.cc(558)] supported is not a known system
C   39.546s Main  ../../media/blink/key_system_config_selector_unittest.cc:184: Failure
C   39.546s Main  Value of: succeeded_count_
C   39.546s Main    Actual: 0
C   39.547s Main  Expected: 1
C   39.547s Main  ../../media/blink/key_system_config_selector_unittest.cc:185: Failure
C   39.547s Main  Value of: not_supported_count_
C   39.547s Main    Actual: 1
C   39.547s Main  Expected: 0
C   39.547s Main  ../../media/blink/key_system_config_selector_unittest.cc:606: Failure
C   39.547s Main  Value of: SelectConfigReturnsConfig()
C   39.547s Main    Actual: false
C   39.547s Main  Expected: true
C   39.547s Main  [  FAILED  ] KeySystemConfigSelectorTest.VideoCapabilities_Codecs_AllSupported (1 ms)
 
Blocking: 661623
Looks like the CL landed, but the test is still failing here :https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroid%20x64/builds/126 Is that expected? (Note: That bot runs on x64 not arm)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20dad01edd41fad0a117a3e734b54afe0931342e

commit 20dad01edd41fad0a117a3e734b54afe0931342e
Author: thakis <thakis@chromium.org>
Date: Fri Nov 04 22:50:52 2016

android/x64 bot: Don't run media_blink_unittests, it doesn't pass on Android.

BUG= 608541 

Review-Url: https://codereview.chromium.org/2480743003
Cr-Commit-Position: refs/heads/master@{#430046}

[modify] https://crrev.com/20dad01edd41fad0a117a3e734b54afe0931342e/testing/buildbot/chromium.fyi.json

Comment 4 by w...@chromium.org, Nov 4 2016

Owner: xhw...@chromium.org
Status: Assigned (was: Available)
Do you know why this might be failing xhwang@?
Components: Internals>Media>Encrypted
Owner: jrumm...@chromium.org
This seems to be related to VideoCapabilities.

jrummell: Could you please take a look?
Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5ac9192f7f5f23c41f51fcf918326920ddc2ac

commit 0c5ac9192f7f5f23c41f51fcf918326920ddc2ac
Author: Hans Wennborg <hans@chromium.org>
Date: Tue May 15 17:02:53 2018

media_blink_unittests: Exclude KeySystemConfigSelectorTest on Android

Bug:  608541 ,  840756 ,  842698 
Change-Id: Iaaaf79dc775a6738cff55037ee9c6ff354530e19
Reviewed-on: https://chromium-review.googlesource.com/1059655
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558755}
[modify] https://crrev.com/0c5ac9192f7f5f23c41f51fcf918326920ddc2ac/media/blink/BUILD.gn

Comment 7 by xhw...@chromium.org, May 15 2018

Labels: -Pri-3 M-68 Pri-1
Cc: -w...@chromium.org -xhw...@chromium.org jrumm...@chromium.org
Owner: xhw...@chromium.org
Status: Started (was: Assigned)
I am updating this test and I believe it'll also fix this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27aa45d864e00eca026ebb9b1efb4e942b398ff5

commit 27aa45d864e00eca026ebb9b1efb4e942b398ff5
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Fri Jun 08 05:37:27 2018

Revert "media_blink_unittests: Exclude KeySystemConfigSelectorTest on Android"

This reverts commit 0c5ac9192f7f5f23c41f51fcf918326920ddc2ac.

The test has been fixed in http://crrev.com/c/1090113.

Bug:  608541 
Change-Id: I040328033921d8b24018761d19ecd923d44d75bf
Reviewed-on: https://chromium-review.googlesource.com/1091883
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565555}
[modify] https://crrev.com/27aa45d864e00eca026ebb9b1efb4e942b398ff5/media/blink/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment