New issue
Advanced search Search tips

Issue 608492 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Jun 2016
Cc:
tommycli@chromium.org
rouslan@chromium.org
jdonnelly@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[People -> Advanced Sync Settings] Wallet Sync mocks

Project Member Reported by tommycli@chromium.org, May 2 2016 
Options now has a 10th datatype to sync:
https://screenshot.googleplex.com/59eiPNOvZAS.png

The existing mocks don't reflect that yet:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-People-sync-settings.png%3Fz=width

Just confirming: We're just adding another item at the end of the list using the exact same text as Options right?

Comment 1 by jdonnelly@chromium.org, May 2 2016 

Yeah, apologies for the fact that it throws off the balance of your now vertical list.

Comment 2 by tbuck...@chromium.org, May 2 2016

Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Yes, this should just be added to the end of the list.

Comment 3 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-PeopleCrOS Hotlist-MD-Settings-People
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5ea77b5636b462910521845296eeb16b8f7403

commit 3a5ea77b5636b462910521845296eeb16b8f7403
Author: tommycli <tommycli@chromium.org>
Date: Thu Jun 16 17:58:17 2016

Settings People Revamp: Add Payments integration to new Sync Settings.

Very similar to this patch: https://codereview.chromium.org/1578173005/

It adds Payments integration to the new MD Settings just like the it
was added to the old Options implementation in Jan 2016.

BUG= 608492 , 563721
TEST=MANUAL
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2068653003
Cr-Commit-Position: refs/heads/master@{#400199}

[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/app/settings_strings.grdp
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/3a5ea77b5636b462910521845296eeb16b8f7403/chrome/test/data/webui/settings/people_page_sync_page_test.js

Comment 5 by tommycli@chromium.org, Jun 16 2016

Cc: rouslan@chromium.org
Status: Fixed (was: Assigned)
Fixed. Thanks Justin and Rouslan for consult.

Comment 6 by tkonch...@chromium.org, Jul 28 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2785.34
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 53.0.2785.34 by enabling the flag --enable-features=MaterialDesignSettings - observed the last option "Credit cards and addresses using google payments" 

Please find the screenshot
Screen Shot 2016-07-28 at 3.13.18 PM.png
195 KB View Download
►

Sign in to add a comment