New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608487 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 608483



Sign in to add a comment

Create Dockerfile for blimp engine environment unittests

Reported by jessi...@chromium.org, May 2 2016

Issue description

Otherwise would need to inject a Dockerfile later on in the process, which would be non-trivially more work.

Would be included in bundle script arguments.
 
Cc: sriramsr@chromium.org
Components: Mobile>Blimp>Engine
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c25b6361957f68f9524ff09f2adcfb58d6cae500

commit c25b6361957f68f9524ff09f2adcfb58d6cae500
Author: jessicag <jessicag@chromium.org>
Date: Tue Jun 07 17:38:50 2016

Support for bundling Chromium unittests into a tarball.

Without this change only the engine binary can be bundled in this way.

This change allows all the required files to successfully run in a
docker container can be bundled together in a tarball and uploaded to a
new location. This makes the process of exporting tests this way easily
repeatable and automatable.

This builds on the manifest generation work of
https://codereview.chromium.org/1997493002/

BUG= 613000 , 608487 , 608483 

Review-Url: https://codereview.chromium.org/2028353003
Cr-Commit-Position: refs/heads/master@{#398324}

[modify] https://crrev.com/c25b6361957f68f9524ff09f2adcfb58d6cae500/blimp/BUILD.gn
[add] https://crrev.com/c25b6361957f68f9524ff09f2adcfb58d6cae500/blimp/Dockerfile
[modify] https://crrev.com/c25b6361957f68f9524ff09f2adcfb58d6cae500/blimp/engine/BUILD.gn
[rename] https://crrev.com/c25b6361957f68f9524ff09f2adcfb58d6cae500/blimp/tools/create-bundle.py

Previous CR only provides a stub Dockerfile.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be16cfb643c62ef097979bfc3db752a02a9c25f5

commit be16cfb643c62ef097979bfc3db752a02a9c25f5
Author: jessicag <jessicag@chromium.org>
Date: Wed Jul 13 20:25:51 2016

Fill in testing Dockerfile stub.

The current Dockerfile uploaded with the testing package is just a NOOP stub.  This change creates a functional stub from the shared base used by test and engine and handles additional filesystem setup steps for testing.

The updated Dockerfile will be used to validate service support.

BUG=616945,  608487 

Review-Url: https://codereview.chromium.org/2136363002
Cr-Commit-Position: refs/heads/master@{#405275}

[modify] https://crrev.com/be16cfb643c62ef097979bfc3db752a02a9c25f5/blimp/engine/testing/Dockerfile

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df4245122709b6a19e5f898d49a777b153c9bd7

commit 6df4245122709b6a19e5f898d49a777b153c9bd7
Author: jessicag <jessicag@chromium.org>
Date: Fri Jul 22 19:58:17 2016

Update ADD handling in Dockerfiles and test bundle creation.

Current Dockerfiles were written with a misunderstanding of how wildcards and directory sources interact with the ADD command. This was discovered in testing using the generated tarballs.

The change fixes an incorrect comment in the engine Dockerfile.

Additionally, create_bundle.py was updated to tar up the filesystem state from a context other than the build directory.

These changes mean that for the env_tests bundle, running the Dockerfile in the context of the tarball results in a system file structure such that /blimp/ contains the set of dpendencies for the testing binaries in the same directory structure as // (the chromium src directory).

This change does not remove the duplicate ./third_party/blimp_fonts (./fonts is used instead) for the engine environment.

BUG=616945,  608487 ,  630438 

Review-Url: https://codereview.chromium.org/2154873002
Cr-Commit-Position: refs/heads/master@{#407237}

[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/BUILD.gn
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/Dockerfile
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/engine/testing/Dockerfile
[modify] https://crrev.com/6df4245122709b6a19e5f898d49a777b153c9bd7/blimp/tools/create-bundle.py

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment