New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608479 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 608483



Sign in to add a comment

Have Script for Creating a Engine Unittest Manifest file

Reported by jessi...@chromium.org, May 2 2016

Issue description

Much like
blimp/tools/generate-engine-manifest.py
but for Blimp's environment unit tests.

At the very least need to expand existing tool to support a whitelist as well.
 
Blocking: 608483
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384cd04b36e53b48e237e601e804ee65d65e2924

commit 384cd04b36e53b48e237e601e804ee65d65e2924
Author: jessicag <jessicag@chromium.org>
Date: Wed May 18 22:26:08 2016

Refactor generate engine manifest to accept blacklist as an argument.

The current manifest generation script assumes a static blacklist, which means it can not be generalized to also support manifest generation for chromium unittests to be used for environment testing deployment.

Updating the script to accept a blacklist as an argument generalizes it so it can be used to generate manifests for both the engine and environment unittests.

BUG= 608479 

Review-Url: https://codereview.chromium.org/1937423002
Cr-Commit-Position: refs/heads/master@{#394576}

[modify] https://crrev.com/384cd04b36e53b48e237e601e804ee65d65e2924/blimp/docs/container.md
[modify] https://crrev.com/384cd04b36e53b48e237e601e804ee65d65e2924/blimp/engine/BUILD.gn
[rename] https://crrev.com/384cd04b36e53b48e237e601e804ee65d65e2924/blimp/tools/engine-manifest-blacklist.txt
[rename] https://crrev.com/384cd04b36e53b48e237e601e804ee65d65e2924/blimp/tools/generate-target-manifest.py

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment