New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608477 link

Starred by 1 user
Status: Verified
Owner:
█ ajnolley@chromium.org
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Windows Host] Cannot connect to host in curtain mode when using a non-default RDP port number

Project Member Reported by joedow@chromium.org, May 2 2016 
While working on a different bug, I realized that our logic to handle non-default RDP ports is broken.  This logic was implemented via  crbug.com/241214  and would have worked for Win XP, however for Win 7 and up, the registry key they query is not accessible by our RDP process so it can never read the updated value.

I am going to update the code so we read the RDP port value from the Daemon process and pass it into the RDP process on creation.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69094d5f4d39b81cce2e5234804c9868d428af76

commit 69094d5f4d39b81cce2e5234804c9868d428af76
Author: joedow <joedow@chromium.org>
Date: Tue May 03 20:00:02 2016

Fixing curtain mode using non-default RDP port for Windows host.

While adding debug logging for the Win 10 curtain mode issue, I realized that
the host was not able to connect to its RDP session if a non-default port
number was set in the registry.  This is because the RDP session runs as
'Local Service' and does not have access to the registry.  This code was
originally added to address  crbug.com/241214  and I think it may have been
implemented and tested on XP where it would work, but it wouldn't have on
later OSes.

My change is to move the code which needs to read the port number from the
registry from the RDP process to the Daemon process.  The port number will
then be passed to the RDP process when it is created.  The code which reads
from the registry will be reused in an upcoming CL so it has been put into
a helper method even though there is only one caller.

BUG= 608477 

Review-Url: https://codereview.chromium.org/1935003003
Cr-Commit-Position: refs/heads/master@{#391335}

[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/chromoting_lib_idl.templ
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/rdp_client.cc
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/rdp_client.h
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/rdp_client_unittest.cc
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/rdp_desktop_session.cc
[modify] https://crrev.com/69094d5f4d39b81cce2e5234804c9868d428af76/remoting/host/win/rdp_desktop_session.h

Comment 2 by joedow@chromium.org, May 3 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, May 19 2016

Labels: OS-Windows

Comment 4 by ajnolley@chromium.org, Jun 11 2016

Status: Verified (was: Fixed)
After changing the default rdp port number, CRD connects. Verified Fixed
►

Sign in to add a comment