New issue
Advanced search Search tips

Issue 608475 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.8%-73.4% regression in blink_perf.parser at 390889:390895

Project Member Reported by lanwei@google.com, May 2 2016

Issue description

See the link to graphs below.
 
Cc: yukishiino@chromium.org
Owner: yukishiino@chromium.org

=== Auto-CCing suspected CL author yukishiino@chromium.org ===

Hi yukishiino@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : binding: Makes Window/Location's attributes accessor-type properties.
Author  : yukishiino
Commit description:
  
Makes almost all the attributes (except for cross-origin accessible
attributes) accessor-type properties.  The target attributes in this
CL are DOM attributes of Window, Location and workers not annotated
as [DoNotCheckSecurity], which are cross-origin accessible.

BUG= 43394 ,  516274 

Review-Url: https://codereview.chromium.org/1380503002
Cr-Commit-Position: refs/heads/master@{#390893}
Commit  : 9ac1750adf85027985c7af3468e0b972c2086235
Date    : Mon May 02 05:05:22 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@390889  281.673  3.03739  5  good
chromium@390892  283.65   1.93121  5  good
chromium@390893  262.226  2.30648  5  bad    <--
chromium@390894  259.791  2.45459  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 608475

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser
Test Metric: query-selector-all-class/query-selector-all-class
Relative Change: 7.77%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6466
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013742488124707856


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5828860281618432

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: haraken@chromium.org
Components: Blink>Bindings
haraken@, do you think that we need to revert the CL?  It's a quite big regression.
Yeah, this looks like a real regression -- we need to revert the CL and investigate.

blink_perf.parsing is a set of relatively simple micro-benchmarks, so I hope it would be easy to identify the regression cause.


Status: Fixed (was: Assigned)
Reverted the CL at https://codereview.chromium.org/1958883003/

Sign in to add a comment