New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608468 link

Starred by 1 user
Status: Fixed
Owner:
█ dyen@chromium.org
Email to this user bounced
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix license check errors for glslang

Reported by dyen@chromium.org, May 2 2016 
The glslang repository is currently not passing the license check, although the fixes are already in progress:

tools/checklicenses/checklicenses.py third_party/glslang/
Using base directory: /usr/local/google/home/dyen/base/chromium/src
Checking: /usr/local/google/home/dyen/base/chromium/src/third_party/glslang

'third_party/glslang/src/index.php' has non-whitelisted license 'UNKNOWN'
'third_party/glslang/src/SetupLinux.sh' has non-whitelisted license 'UNKNOWN'

FAILED

This issue is to be sure it is not forgotten. The following pull request is meant to fix the issue:

https://github.com/KhronosGroup/glslang/pull/256

Comment 1 by dyen@chromium.org, May 10 2016

Status: Fixed (was: Untriaged)
Pull request has been merged.
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b780ac58cfda43ae83ccb684c3f717cdeb827969

commit b780ac58cfda43ae83ccb684c3f717cdeb827969
Author: dyen <dyen@chromium.org>
Date: Tue May 10 19:02:41 2016

Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG= 582558 ,  608468 

Review-Url: https://codereview.chromium.org/1917043003
Cr-Commit-Position: refs/heads/master@{#392667}

[modify] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/.gitignore
[modify] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/DEPS
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/SPIRV-Tools/LICENSE
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/SPIRV-Tools/OWNERS
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/SPIRV-Tools/README.chromium
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/glslang/LICENSE
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/glslang/OWNERS
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/glslang/README.chromium
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/shaderc/LICENSE
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/shaderc/OWNERS
[add] https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969/third_party/shaderc/README.chromium
►

Sign in to add a comment