New issue
Advanced search Search tips

Issue 608460 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 651746



Sign in to add a comment

Consider implementing URL.createFor()

Project Member Reported by jsb...@chromium.org, May 2 2016

Issue description

Spec:

https://w3c.github.io/FileAPI/#dfn-createFor

Note that no other browsers implement it yet, since auto-revoking has lots of edge cases that have not been fully thought through.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e232c512c962a7aecc85e07f7a48a4735dc7a25

commit 9e232c512c962a7aecc85e07f7a48a4735dc7a25
Author: jsbell <jsbell@chromium.org>
Date: Thu May 12 16:38:57 2016

Don't expose URL.createObjectURL and revokeObjectURL to Service Workers

Per FileAPI[1] which was updated based on Service Worker discussion[2],
minting blob URLs should not be possible within SWs.

A bug has been filed against MediaSource[3] to update the IDL there
(following the same logic), and mediastream's createObjectURL is no
longer present in the standard. Regardless, the overloads should
never execute in Service Workers as those types (MediaStream,
MediaSource) are not exposed in that context.

Note that the [Exposed] attributes are applied directly to the
interface members as they appear to be ignored on the partial
interface. (Bug?)

[1] https://w3c.github.io/FileAPI/#creating-revoking
[2] https://github.com/slightlyoff/ServiceWorker/issues/688
[3] https://github.com/w3c/media-source/issues/67

Intent Thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoeyBwAJ

BUG= 604951 , 608460 

Review-Url: https://codereview.chromium.org/1908263002
Cr-Commit-Position: refs/heads/master@{#393271}

[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/scheme-blob.js
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/core/fileapi/URLFileAPI.idl
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/modules/mediasource/URLMediaSource.idl
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp
[modify] https://crrev.com/9e232c512c962a7aecc85e07f7a48a4735dc7a25/third_party/WebKit/Source/modules/mediastream/URLMediaStream.idl

Comment 2 by jsb...@chromium.org, Sep 30 2016

Blocking: 651746
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/def385069852caae569f604404841e9b6a51aa57

commit def385069852caae569f604404841e9b6a51aa57
Author: mek <mek@chromium.org>
Date: Mon Feb 06 19:22:00 2017

Remove no longer applicable FileAPI comments.

The spec removed createFor and changed FileReader.error to DOMException.
This removes now outdated comments for these changes.

BUG= 608460 

Review-Url: https://codereview.chromium.org/2663333003
Cr-Commit-Position: refs/heads/master@{#448345}

[modify] https://crrev.com/def385069852caae569f604404841e9b6a51aa57/third_party/WebKit/Source/core/fileapi/FileReader.idl
[modify] https://crrev.com/def385069852caae569f604404841e9b6a51aa57/third_party/WebKit/Source/core/fileapi/URLFileAPI.idl

Comment 4 by mek@chromium.org, Feb 6 2017

Status: WontFix (was: Available)
Closing this since the spec no longer defines createFor
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Sign in to add a comment