New issue
Advanced search Search tips

Issue 608459 link

Starred by 1 user
Status: Fixed
Owner:
nzolghadr@chromium.org
Closed: Jun 2016
Cc:
rbyers@chromium.org
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

PointerEvents: default value of width/height should be 1

Project Member Reported by mustaq@chromium.org, May 2 2016 
We currently report h=w=0 for both mouse & stylus. Edge reports h=w=1.

The spec is a bit open about what to do, but Edge's behavior makes more sense:
"For devices which have a contact geometry but the actual geometry is not reported by the hardware, a default value should be provided by the user agent to approximate the geometry typical of that pointer type. Otherwise, the value must be 0."

Comment 1 by nzolghadr@chromium.org, May 2 2016

Cc: rbyers@chromium.org
Do you think it is worth to make the spec more accurate in this case or having it like what it is looks okay?

Comment 2 by mustaq@chromium.org, May 3 2016 

The current wording looks reasonably okay. I am weakly biased to having a note about mouse pointer size being 1x1. If you agree, please go ahead with the spec change. In any case, we need to fix our implementation.

Comment 3 by nzolghadr@chromium.org, May 16 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ca22269406e17f2e67caaa5e01167736ccc86b

commit 69ca22269406e17f2e67caaa5e01167736ccc86b
Author: nzolghadr <nzolghadr@chromium.org>
Date: Mon May 16 14:36:58 2016

Set width=height=1 of mouse like pointer events

Right now these devices don't report any geometry
and there is no plumbing to set these values in
the lower levels. So for now we just set them in
PointerEventFactory.

BUG= 608459 

Review-Url: https://codereview.chromium.org/1968653005
Cr-Commit-Position: refs/heads/master@{#393829}

[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/69ca22269406e17f2e67caaa5e01167736ccc86b/third_party/WebKit/Source/core/input/PointerEventManager.h

Comment 5 by nzolghadr@chromium.org, May 31 2016

Status: Started (was: Fixed)
After this change to the spec we should set the default width/height to 1 instead.
https://github.com/w3c/pointerevents/pull/69

Comment 6 by nzolghadr@chromium.org, May 31 2016

Summary: PointerEvents: default value of width/height should be 1 (was: PointerEvents: width/height of mouse & stylus should be 1)

Comment 8 by nzolghadr@chromium.org, Jun 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment