New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608439 link

Starred by 1 user
Status: Verified
Owner:
jwer...@chromium.org
Closed: May 2016
Cc:
█ pgeorgi@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

emerge-veyron_jerry coreboot fails due to 'Bootblock exceeded its allotted size! (18K - 4)'

Project Member Reported by dnojiri@chromium.org, May 2 2016 
emerge-veyron_jerry coreboot fails due to 'Bootblock exceeded its allotted size! (18K - 4)'. bisecting revealed the following CL to blame:

commit c4af2a4ad4d6eea551653ca300ea6d04f1280919
Author: Patrick Georgi <patrick@georgi-clan.de>
Date:   Thu Apr 28 08:02:14 2016 +0200

    rockchip/spi: Allow SPI buses > 2
    
    If SPI_BASEx is defined (for 2 < x <= 5), allow selecting it.
    Since the bus number translates into an offset into an array, require
    that all earlier buses are defined, too.
    
    Also assert() that the array is properly sized instead of blindly
    exceeding its bounds when called with a too big bus number.
    
    TEST=initializing bus 5 doesn't trap anymore on kevin
    BRANCH=none
    BUG=none
    
    Change-Id: I27724d64d822ed0ec824a69ed611140bfbe08f5a
    Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
    Reviewed-on: https://chromium-review.googlesource.com/341034
    Commit-Ready: Vadim Bendebury <vbendeb@chromium.org>
    Tested-by: Vadim Bendebury <vbendeb@chromium.org>
    Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2016

Labels: merge-merged-chromeos-2016.02
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/fb7a101daba4f4f899a9c907b29d908661aa2dae

commit fb7a101daba4f4f899a9c907b29d908661aa2dae
Author: Julius Werner <jwerner@chromium.org>
Date: Mon May 02 20:06:08 2016

rk3288: Shuffle memlayout to make it fit

Another day, another overflowing RK3288 stage. There's almost 2K of
space left in verstage/romstage (*gasp*, such waste!), so let's move one
of them over to the bootblock. (We now have no whole kilobyte left that
I can see...)

BRANCH=None
BUG= chromium:608439 
TEST=Built Jerry

Change-Id: Ib72c0b3718aac38bc97c898a74aa5757e46cef0b
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/341742
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

[modify] https://crrev.com/fb7a101daba4f4f899a9c907b29d908661aa2dae/src/soc/rockchip/rk3288/include/soc/memlayout.ld

Comment 2 by jwer...@chromium.org, May 3 2016

Cc: -jwer...@chromium.org pgeorgi@chromium.org
Owner: jwer...@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by patricia@chromium.org, May 23 2016 

Bulk verified

Comment 4 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment