Location bar text changes colors when you type in Incognito mode (Mac) |
|||
Issue descriptionVersion: 52.0.2722.0 OS: 10.11 What steps will reproduce the problem? (1) Create an Incognito window (2) Type and - the Omnibox should match android.com (3) Press Delete to delete one character of typing What is the expected output? Probably that the typed text always remain a light shade of gray What do you see instead? The typed text is a light gray when it matches a domain name suggestion, but black when it does not. When the Omnibox displays a URL it shows different portions of the URL in different colors in Incognito mode. I suspect that the Omnibox is just applying its coloring logic to the text in the location bar, so that when there is no domain it applies a color for text that is not a domain. sebastien@, should the location bar text be presented in the same color at all times when you're typing text into it? If so, what color?
,
May 2 2016
What you attached is not typing but steady state. In incognito, the http goes from green to #fff 0.5 as well as anything other than the domain, just like in normal Chrome.
,
May 2 2016
Just trying to make sure I understand what needs to happen. So while editing, Incognito text is #FFF, at 100% I assume? Non-Incognito is #000 at 100% or 50%?
,
May 2 2016
Incognito typing text is always 100% #FFF Incognito domain is always 100% #FFF HTTP(s) indicator in incognito as well as URL path/parameters and "://" are 50% #FFF In normal mode. Text is #000 when typing. #0B8043 for https or #C53929 for broken https. URL path/parameters are 50% #000 as well as the "://"
,
May 2 2016
Perfect - thank you.
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c850fd0f9bd765aa5cd9fffd286cdb9f0cd9d2b4 commit c850fd0f9bd765aa5cd9fffd286cdb9f0cd9d2b4 Author: shrike <shrike@chromium.org> Date: Tue May 03 16:34:12 2016 [Mac][Material Design] Correct location bar editing text colors. Currently the Omnibox formats the location bar's text using its normal formatting rules, which means that if you type a URL the URL will be white, but if what you're typing doesn't look like a URL it will be black (which is probably the Omnibox defaulting to not knowing what to do color-wise). This cl forces the location bar's text to be white or black while editing in normal or Incognito mode, respectively, per the Material Design spec. This cl also cleans up some style mistakes I made in an earlier cl. R=tapted@chromium.org BUG= 608437 Review-Url: https://codereview.chromium.org/1938243002 Cr-Commit-Position: refs/heads/master@{#391263} [modify] https://crrev.com/c850fd0f9bd765aa5cd9fffd286cdb9f0cd9d2b4/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm [modify] https://crrev.com/c850fd0f9bd765aa5cd9fffd286cdb9f0cd9d2b4/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
,
May 3 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sgabr...@chromium.org
, May 2 2016