New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608423 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Rename InkDrop* classes to reduce verbosity

Project Member Reported by bruthig@chromium.org, May 2 2016

Issue description

The material design InkDrop* classes have become quite verbose with words that don't add much value. 
 
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c4be6dcc782031c6b7e0e568ca1a187499f144

commit d4c4be6dcc782031c6b7e0e568ca1a187499f144
Author: bruthig <bruthig@chromium.org>
Date: Mon May 02 22:18:58 2016

Rename of InkDropAnimation classes to InkDropRipple.

The term 'Animation' is too overloaded with respect to the InkDrop.

BUG= 608423 

Review-Url: https://codereview.chromium.org/1937103003
Cr-Commit-Position: refs/heads/master@{#391069}

[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/chrome/browser/ui/views/download/download_item_view_md.h
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/flood_fill_ink_drop_ripple.cc
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/flood_fill_ink_drop_ripple.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_animation_controller.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_host.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_host_view.h
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_ripple.cc
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_ripple.h
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_ripple_observer.h
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/ink_drop_ripple_unittest.cc
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/square_ink_drop_ripple.cc
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/square_ink_drop_ripple.h
[rename] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/square_ink_drop_ripple_unittest.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.cc
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/ink_drop_animation_test_api.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/ink_drop_animation_test_api.h
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/ink_drop_ripple_test_api.cc
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/ink_drop_ripple_test_api.h
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/square_ink_drop_animation_test_api.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/square_ink_drop_animation_test_api.h
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/square_ink_drop_ripple_test_api.cc
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/square_ink_drop_ripple_test_api.h
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/test_ink_drop_animation_observer.cc
[delete] https://crrev.com/bd3c5c2acd055847d83908812562c9baaf594a64/ui/views/animation/test/test_ink_drop_animation_observer.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/test_ink_drop_animation_observer_helper.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/test_ink_drop_host.h
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/test_ink_drop_ripple_observer.cc
[add] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/animation/test/test_ink_drop_ripple_observer.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/controls/button/label_button.h
[modify] https://crrev.com/d4c4be6dcc782031c6b7e0e568ca1a187499f144/ui/views/views.gyp

Labels: -M-52
Project Member

Comment 5 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b9c5c0f873d94b4330352d32065ab2fdaf092f

commit e0b9c5c0f873d94b4330352d32065ab2fdaf092f
Author: bruthig <bruthig@chromium.org>
Date: Wed May 04 21:05:16 2016

Rename of InkDropAnimationController classes to InkDrop.

DEPENDS ON: https://codereview.chromium.org/1937103003/

The term 'AnimationController' was too verbose and didn't add any value.

BUG= 608423 

Review-Url: https://codereview.chromium.org/1937353002
Cr-Commit-Position: refs/heads/master@{#391641}

[modify] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/chrome/browser/ui/views/toolbar/back_button.cc
[modify] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/button_ink_drop_delegate.cc
[modify] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/button_ink_drop_delegate.h
[rename] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop.h
[delete] https://crrev.com/0f5b86386accbd17d06a26475df674a2e1df8bf2/ui/views/animation/ink_drop_animation_controller_factory.cc
[delete] https://crrev.com/0f5b86386accbd17d06a26475df674a2e1df8bf2/ui/views/animation/ink_drop_animation_controller_factory.h
[delete] https://crrev.com/0f5b86386accbd17d06a26475df674a2e1df8bf2/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
[delete] https://crrev.com/0f5b86386accbd17d06a26475df674a2e1df8bf2/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_factory.cc
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_factory.h
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_factory_unittest.cc
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_impl.cc
[rename] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_impl.h
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/ink_drop_impl_unittest.cc
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/test/ink_drop_impl_test_api.cc
[add] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/animation/test/ink_drop_impl_test_api.h
[modify] https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f/ui/views/views.gyp

Status: Fixed (was: Started)
Labels: M-52 OS-Chrome OS-Linux OS-Windows

Sign in to add a comment