Checkbox `checked` state is erroneously influenced by value of `defaultChecked`
Reported by
laser...@gmail.com,
May 2 2016
|
||||||
Issue description
Chrome Version: 50.0.2661.86
URLs (if applicable):
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Firefox: OK (46.0)
What steps will reproduce the problem?
(1) Open https://jsfiddle.net/wsa679ht/
What is the expected result?
Checkbox should be checked.
What happens instead?
Checkbox is not checked.
Please provide any additional information below. Attach a screenshot if
possible.
Checkbox state is explicitly set and should no longer be influenced by defaultValue.
,
May 3 2016
The above behavior is reproducible on All-OS (Windows (10 & 7), Mac 10.11.4 & Ubuntu 14.04) with chrome versions : 50.0.2661.94(Stable), 51.0.2704.22(Beta), 52.0.2716.0 & 52.0.2722.0(Canary). This is a non regression issue as can be seen from M30 build - 30.0.1549.0. Hence marking the same as Untriaged. Thank you!
,
May 6 2016
Ah, easy bug. We should do "m_reflectsCheckedAttribute = false;" before the first |if| in HTMLInputElement::setChecked().
,
May 6 2016
Would like to work on this.
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c commit bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c Author: ramya.v <ramya.v@samsung.com> Date: Fri May 06 10:49:13 2016 Explicitly set checkbox state should not be influenced by defaultState BUG= 608416 Review-Url: https://codereview.chromium.org/1956453004 Cr-Commit-Position: refs/heads/master@{#392030} [add] https://crrev.com/bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html [modify] https://crrev.com/bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
May 6 2016
,
May 6 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by laser...@gmail.com
, May 2 2016