codesearch compile failures show up in the chromium tab on sheriff-o-matic, but don't fail the build. |
||||||||
Issue descriptionSee, e.g.: https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/2161 The compile failure showed up on sheriff-o-matic, but the build didn't turn red. I thought this indicated a bug in the recipe (i.e., the build should've also failed), but martiniss@ thought that this was correctly non fatal. However, he also thought that this shouldn't have shown up on sheriff-o-matic (at least not in the chromium sheriff tab). Can someone take a look and confirm one way or another?
,
May 2 2016
sgtm, but someone should check if any of the builders on infra.cron really do belong on a chromium waterfall instead.
,
May 3 2016
Gnumbd failures really do need to be visible to sheriffs: if gnumbd being down is the reason no commits are landing on tip-of-tree, they need to know that so they can answer the inevitable questions. Other than that, infra.cron shouldn't be part of the chromium tree. +stip to help figure out how to correctly set up gatekeeper-ng so only gnumbd is included.
,
May 3 2016
From my understanding, alerts on sheriff-o-matic are supposed to be actionable by the sheriffs, and sheriffs don't know how to (and aren't supposed to) fix gnumbd. That's the troopers job, since it's a cron we run. The troopers job can be to tell the sheriff's it's broken, so they know how to answer the question, but I don't see the point in sending them an alert if they can't fix the problem. There is playbook entry for gnumbd (https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/troopers/playbook.md#GnumbdBuilderFailuresAlert), so troopers can be roughly be expected to fix it. Gatekeeper's configuration isn't the problem; it's the problem of builder alerts, which is generating these alerts before it applies (the wrong interpretation of) gatekeeper rules.
,
Jun 29 2016
,
Jun 29 2016
,
Sep 1 2016
,
Feb 10 2017
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by martiniss@chromium.org
, May 2 2016