New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608405 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

codesearch compile failures show up in the chromium tab on sheriff-o-matic, but don't fail the build.

Project Member Reported by dpranke@chromium.org, May 2 2016

Issue description

See, e.g.:

https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/2161

The compile failure showed up on sheriff-o-matic, but the build didn't turn red.

I thought this indicated a bug in the recipe (i.e., the build should've also failed), but martiniss@ thought that this was correctly non fatal. However, he also thought that this shouldn't have shown up on sheriff-o-matic (at least not in the chromium sheriff tab).

Can someone take a look and confirm one way or another?
 
Cc: jparent@chromium.org
I've looked at this; I believe it's showing up because infra.cron is configured to be a part of the chromium tree (because of gnumbd, originally), and so any failing build on there gets alerted for. It doesn't get filtered out because there isn't a rule to filter it out in gatekeeper.

I think we should remove infra.cron from the chromium tree, and make the trooper deal with these errors instead. 
sgtm, but someone should check if any of the builders on infra.cron really do belong on a chromium waterfall instead.
Cc: stip@chromium.org
Gnumbd failures really do need to be visible to sheriffs: if gnumbd being down is the reason no commits are landing on tip-of-tree, they need to know that so they can answer the inevitable questions. Other than that, infra.cron shouldn't be part of the chromium tree.

+stip to help figure out how to correctly set up gatekeeper-ng so only gnumbd is included.
From my understanding, alerts on sheriff-o-matic are supposed to be actionable by the sheriffs, and sheriffs don't know how to (and aren't supposed to) fix gnumbd. That's the troopers job, since it's a cron we run. The troopers job can be to tell the sheriff's it's broken, so they know how to answer the question, but I don't see the point in sending them an alert if they can't fix the problem. There is playbook entry for gnumbd (https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/troopers/playbook.md#GnumbdBuilderFailuresAlert), so troopers can be roughly be expected to fix it. 

Gatekeeper's configuration isn't the problem; it's the problem of builder alerts, which is generating these alerts before it applies (the wrong interpretation of) gatekeeper rules.  
Components: Infra>Sheriffing>Gatekeeper
Components: -Infra>Sheriffing
Status: Available (was: Untriaged)

Comment 8 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment