New issue
Advanced search Search tips

Issue 608385 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 601636
issue 614235
issue 616658

Blocking:
issue 560588



Sign in to add a comment

Add support for Video Encode Accelerator in VideoTrackRecorder

Project Member Reported by mcasas@chromium.org, May 2 2016

Issue description

Blockedon: 601636
Blocking: 560588
Cc: m...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b5ab718cb4cf10180e2ce458dbddd9db300a25

commit 66b5ab718cb4cf10180e2ce458dbddd9db300a25
Author: emircan <emircan@chromium.org>
Date: Mon May 16 21:05:47 2016

Change VideoTrackRecorder to operate on a given task runner

This CL modified VideoTrackRecorder so that it can perform encoding
interactions on a given task runner. This change is necessary since VEA
operations happen on a given task runner from GpuFactories.

This CL is [1 of 2] to add support for Video Encode Accelerator in
VideoTrackRecorder.
Playground CL: https://codereview.chromium.org/1934093002/

BUG= 608385 
TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html

Review-Url: https://codereview.chromium.org/1981633002
Cr-Commit-Position: refs/heads/master@{#393913}

[modify] https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25/content/renderer/media/video_track_recorder.cc

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582f00447d5ec6830b202304429f552904f813df

commit 582f00447d5ec6830b202304429f552904f813df
Author: emircan <emircan@chromium.org>
Date: Mon May 23 23:33:15 2016

Add VEAEncoder to VideoTrackRecorder

This CL introduces VEAEncoder which is responsible for handling
GPU encoder interactions for VideoTrackRecorder. VideoTrackRecorder
prioritizes VEAEncoders before SW implementations.

This CL is [2 of 2] to add support for Video Encode Accelerator in
VideoTrackRecorder.
Playground CL: https://codereview.chromium.org/1934093002/

BUG= 608385 
TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html

Review-Url: https://codereview.chromium.org/1990643002
Cr-Commit-Position: refs/heads/master@{#395464}

[modify] https://crrev.com/582f00447d5ec6830b202304429f552904f813df/content/renderer/media/media_recorder_handler.cc
[modify] https://crrev.com/582f00447d5ec6830b202304429f552904f813df/content/renderer/media/video_track_recorder.cc
[modify] https://crrev.com/582f00447d5ec6830b202304429f552904f813df/content/renderer/media/video_track_recorder.h

Blockedon: 614235
Blockedon: 616658
Blockedon: 616659
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0924bc046223e0c9eac949c35c69844c4bfd7513

commit 0924bc046223e0c9eac949c35c69844c4bfd7513
Author: emircan <emircan@chromium.org>
Date: Wed Jul 13 03:35:53 2016

Initialize based on frame sizes in VideoTrackRecorder

This CL modifies the current behavior of VideoTrackRecorder, such that
instead of initializing the underlying |encoder_| in ctor, we wait till the
first frame arrives. Based on the frame size, we choose the appropriate
HW/SW encoder.

BUG= 608385 
TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html

Review-Url: https://codereview.chromium.org/2000003002
Cr-Commit-Position: refs/heads/master@{#404966}

[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder.cc
[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder.h
[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0924bc046223e0c9eac949c35c69844c4bfd7513

commit 0924bc046223e0c9eac949c35c69844c4bfd7513
Author: emircan <emircan@chromium.org>
Date: Wed Jul 13 03:35:53 2016

Initialize based on frame sizes in VideoTrackRecorder

This CL modifies the current behavior of VideoTrackRecorder, such that
instead of initializing the underlying |encoder_| in ctor, we wait till the
first frame arrives. Based on the frame size, we choose the appropriate
HW/SW encoder.

BUG= 608385 
TEST=https://cdn.rawgit.com/miguelao/demos/master/mediarecorder.html

Review-Url: https://codereview.chromium.org/2000003002
Cr-Commit-Position: refs/heads/master@{#404966}

[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder.cc
[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder.h
[modify] https://crrev.com/0924bc046223e0c9eac949c35c69844c4bfd7513/content/renderer/media/video_track_recorder_unittest.cc

Status: Fixed (was: Started)
Blockedon: -616659 -601636
Blockedon: 601636

Sign in to add a comment