New issue
Advanced search Search tips

Issue 608383 link

Starred by 3 users
Status: Verified
Owner:
k...@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Right-click menu shows deselected "English (Australian)" when I select "English (United Kingdom)" in chrome://settings/languages

Project Member Reported by rouslan@chromium.org, May 2 2016 
Chrome version: 51.0.2704.22 (Official Build) beta (64-bit)

This could be related to krb@'s recent changes to unify the data files behind several languages.

krb@, please investigate.
Screenshot from 2016-05-02 09:34:07.png
53.5 KB View Download
Screenshot from 2016-05-02 09:35:08.png
46.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4eea63cf1d51f5d1e2ba4a6e3047f622438148

commit ca4eea63cf1d51f5d1e2ba4a6e3047f622438148
Author: krb <krb@chromium.org>
Date: Wed May 04 18:19:56 2016

In 'GetCorrespondingSpellCheckLanguage()', we were
finding the first language whose region matched the
incoming language. For example, it would find 'en-GB'
in the region and assume that the primary language
was 'en-AU'. Changed to continue searching to see if
there is a perfect match later in the language field.

BUG= 608383 

Review-Url: https://codereview.chromium.org/1937203002
Cr-Commit-Position: refs/heads/master@{#391566}

[modify] https://crrev.com/ca4eea63cf1d51f5d1e2ba4a6e3047f622438148/chrome/browser/spellchecker/spellcheck_service_unittest.cc
[modify] https://crrev.com/ca4eea63cf1d51f5d1e2ba4a6e3047f622438148/chrome/common/spellcheck_common.cc

Comment 2 by k...@chromium.org, Jun 17 2016

Status: Fixed (was: Assigned)

Comment 3 by son...@google.com, Aug 1 2016

Status: Verified (was: Fixed)
Verified on build 8659.0.0

Comment 4 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment