New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608371 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 576261



Sign in to add a comment

PlzNavigate: properly execute the BeforeUnload event

Project Member Reported by clamy@chromium.org, May 2 2016

Issue description

Currently PlzNavigate doesn't execute the BeforeUnload event at the right point in time during renderer-initiated navigations. This should be fixed.
 

Comment 1 by clamy@chromium.org, May 2 2016

Blocking: 576261
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd6a8144791f47eefb45961819c6f3472035506

commit bfd6a8144791f47eefb45961819c6f3472035506
Author: clamy <clamy@chromium.org>
Date: Mon May 30 16:25:17 2016

PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

This CL ensures that the BeforeUnload event is always properly executed before
starting a renderer-initiated navigation when browser-side-navigation is
enabled.

BUG= 608371 , 475027 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1890493002
Cr-Commit-Position: refs/heads/master@{#396737}

[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/components/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/common/frame_messages.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/content/renderer/render_frame_impl.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/bfd6a8144791f47eefb45961819c6f3472035506/third_party/WebKit/public/web/WebLocalFrame.h

Comment 3 by clamy@chromium.org, Apr 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment