New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 586386



Sign in to add a comment

video_decode_accelerator_unittest no longer builds on Windows in component builds

Project Member Reported by thakis@chromium.org, May 2 2016

Issue description

> set GYP_DEFINES=fastbuild=1 component=shared_library
> python build\gyp_chromium
> ninja -C out\Release video_decode_accelerator_unittest

ninja: Entering directory `out\Release'
[4489/4489] LINK_EMBED video_decode_accelerator_unittest.exe
FAILED: video_decode_accelerator_unittest.exe video_decode_accelerator_unittest.exe.pdb
c:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True video_decode_accelerat
or_unittest.exe "c:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /n
ologo /OUT:video_decode_accelerator_unittest.exe @video_decode_accelerator_unittest.exe.rsp" 1 mt.exe rc.exe "obj\media\
video_decode_accelerator_unittest.video_decode_accelerator_unittest.exe.intermediate.manifest" obj\media\video_decode_ac
celerator_unittest.video_decode_accelerator_unittest.exe.generated.manifest ..\..\build\win\compatibility.manifest
video_decode_accelerator_unittest.video_decode_accelerator_unittest.obj : warning LNK4217: locally defined symbol ??0Fak
eVideoDecodeAccelerator@media@@QAE@ABVSize@gfx@@ABV?$Callback@$$A6A_NXZ$00@base@@@Z (public: __thiscall media::FakeVideo
DecodeAccelerator::FakeVideoDecodeAccelerator(class gfx::Size const &,class base::Callback<bool __cdecl(void),1> const &
)) imported in function "public: void __thiscall media::`anonymous namespace'::GLRenderingVDAClient::CreateAndStartDecod
er(void)" (?CreateAndStartDecoder@GLRenderingVDAClient@?A0xcf38b526@media@@QAEXXZ)
video_decode_accelerator_unittest.video_decode_accelerator_unittest.obj : warning LNK4217: locally defined symbol ??1Fak
eVideoDecodeAccelerator@media@@UAE@XZ (public: virtual __thiscall media::FakeVideoDecodeAccelerator::~FakeVideoDecodeAcc
elerator(void)) imported in function "public: virtual void * __thiscall media::FakeVideoDecodeAccelerator::`scalar delet
ing destructor'(unsigned int)" (??_GFakeVideoDecodeAccelerator@media@@UAEPAXI@Z)
video_decode_accelerator_unittest.video_decode_accelerator_unittest.obj : error LNK2019: unresolved external symbol "__d
eclspec(dllimport) public: __thiscall media::GpuVideoDecodeAcceleratorFactoryImpl::~GpuVideoDecodeAcceleratorFactoryImpl
(void)" (__imp_??1GpuVideoDecodeAcceleratorFactoryImpl@media@@QAE@XZ) referenced in function "public: virtual __thiscall
 media::`anonymous namespace'::GLRenderingVDAClient::~GLRenderingVDAClient(void)" (??1GLRenderingVDAClient@?A0xcf38b526@
media@@UAE@XZ)
video_decode_accelerator_unittest.video_decode_accelerator_unittest.obj : error LNK2019: unresolved external symbol "__d
eclspec(dllimport) public: static class std::unique_ptr<class media::GpuVideoDecodeAcceleratorFactoryImpl,struct std::de
fault_delete<class media::GpuVideoDecodeAcceleratorFactoryImpl> > __cdecl media::GpuVideoDecodeAcceleratorFactoryImpl::C
reate(class base::Callback<class gfx::GLContext * __cdecl(void),1> const &,class base::Callback<bool __cdecl(void),1> co
nst &,class base::Callback<bool __cdecl(unsigned int,unsigned int,class scoped_refptr<class gl::GLImage> const &,bool),1
> const &)" (__imp_?Create@GpuVideoDecodeAcceleratorFactoryImpl@media@@SA?AV?$unique_ptr@VGpuVideoDecodeAcceleratorFacto
ryImpl@media@@U?$default_delete@VGpuVideoDecodeAcceleratorFactoryImpl@media@@@std@@@std@@ABV?$Callback@$$A6APAVGLContext
@gfx@@XZ$00@base@@ABV?$Callback@$$A6A_NXZ$00@6@ABV?$Callback@$$A6A_NIIABV?$scoped_refptr@VGLImage@gl@@@@_N@Z$00@6@@Z) re
ferenced in function "public: void __thiscall media::`anonymous namespace'::GLRenderingVDAClient::CreateAndStartDecoder(
void)" (?CreateAndStartDecoder@GLRenderingVDAClient@?A0xcf38b526@media@@QAEXXZ)
video_decode_accelerator_unittest.video_decode_accelerator_unittest.obj : error LNK2019: unresolved external symbol "__d
eclspec(dllimport) public: class std::unique_ptr<class media::VideoDecodeAccelerator,struct std::default_delete<class me
dia::VideoDecodeAccelerator> > __thiscall media::GpuVideoDecodeAcceleratorFactoryImpl::CreateVDA(class media::VideoDecod
eAccelerator::Client *,struct media::VideoDecodeAccelerator::Config const &,struct gpu::GpuPreferences const &)" (__imp_
?CreateVDA@GpuVideoDecodeAcceleratorFactoryImpl@media@@QAE?AV?$unique_ptr@VVideoDecodeAccelerator@media@@U?$default_dele
te@VVideoDecodeAccelerator@media@@@std@@@std@@PAVClient@VideoDecodeAccelerator@2@ABUConfig@62@ABUGpuPreferences@gpu@@@Z)
 referenced in function "public: void __thiscall media::`anonymous namespace'::GLRenderingVDAClient::CreateAndStartDecod
er(void)" (?CreateAndStartDecoder@GLRenderingVDAClient@?A0xcf38b526@media@@QAEXXZ)
video_decode_accelerator_unittest.exe : fatal error LNK1120: 3 unresolved externals

Very likely https://codereview.chromium.org/1882373004, trying to revert.
 
Cc: r...@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/1937093002/ fixes.
Blocking: 586386
Status: Fixed (was: Started)

Sign in to add a comment