New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608341 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 487345



Sign in to add a comment

override, don't remove, user gesture requirement in autoplay experiment

Project Member Reported by liber...@chromium.org, May 2 2016

Issue description

rather than remove the user gesture requirement when autoplay is allowed, instead just override it for the instance.
 
Labels: M-52
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb

commit 1301c3d6b3ea7b0ace8849580eaecd311c83b7bb
Author: liberato <liberato@chromium.org>
Date: Wed May 18 21:43:55 2016

Don't remove the gesture requirement in the autoplay experiment.

Instead of permanently unlocking the media element when the autoplay
experiment permits autoplay, leave the element locked and override
the gesture requirement for the particular play request.

This also turns off deferred playback due to mute changes.  Instead,
checks for muted media are applied only when the playback is
attempted.  Only visibility requirements are deferred.

BUG= 608341 

Review-Url: https://codereview.chromium.org/1949633002
Cr-Commit-Position: refs/heads/master@{#394558}

[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/1301c3d6b3ea7b0ace8849580eaecd311c83b7bb/third_party/WebKit/Source/core/html/HTMLMediaElement.h

Status: Fixed (was: Assigned)

Sign in to add a comment