Remove IDC_SHOW_SIGN_IN_WITH_RESHARE_ON_COMPLETION |
|||
Issue descriptionContext: A long long time ago, chrome implemented its own Share menu. The flow was (assuming the user was not signed in for the sharing): -Start sharing to gmail -Sharing to gmail requires to be signed-in, so show a webview with a sign-in form. -Once the user is signed-in, start the sharing process again. This flow is not possible anymore, so a bunch of functions like |showSignInAndReshareOnCompletion| can be removed.
,
May 30 2016
,
May 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e4bf5505560d0008e9a575b0b22f473266cabb5e commit e4bf5505560d0008e9a575b0b22f473266cabb5e Author: jif <jif@google.com> Date: Mon May 30 13:26:23 2016
,
May 30 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c96540b3310595f91818ad186c0c017996dd314 commit 0c96540b3310595f91818ad186c0c017996dd314 Author: jif <jif@chromium.org> Date: Thu Jun 02 18:24:26 2016 Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG= 608337 Review-Url: https://codereview.chromium.org/2020023002 Cr-Commit-Position: refs/heads/master@{#397475} [modify] https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314/ios/chrome/browser/signin/constants.h [modify] https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314/ios/chrome/browser/ui/commands/ios_command_ids.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by jif@chromium.org
, May 30 2016