New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608317 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Downloaded records does not appear back after deleting the value from 'Search box'.

Reported by yfulgaon...@etouch.net, May 2 2016

Issue description

Chrome version : 52.0.2722.0 (Official Build) 884d81a6495cd1138a77425df55d80030b768de1-refs/heads/master@{#390853} 32/64 bit
OS :  Windows (7, 8, 10), Linux (ubuntu 14.04 LTS), Mac (10.10.5)(10.11.4)

URL : http://mirror.internode.on.net/pub/test/

What steps will reproduce the problem?
1. Launch chrome, go to above url, download any file and click on 'Show all downloads'.
2. Click on 'Search' icon and enter any wrong value in 'Search box'.
3. Now delete this value from 'Search box' using Backspace key and observe the current Download records.

Actual : After step 3, Download records does not appear back.  
Expected : After step 3, all downloaded records should be seen.

This is a regression issue, broken in 'M-52', below is manual bisect and narrow bisect info:
Good Build : 52.0.2715.0
Bad Build : 52.0.2716.0

Narrow Bisect info:
 https://chromium.googlesource.com/chromium/src/+log/e093c0fd8932f89485db88e533d88aef724cd287..ef9f45d785bb1e4bd694ff024bf3ba6ef5b15244?pretty=fuller&n=10000

Suspecting : r389218 from Narrow Bisect

 
Actual_downloads.mp4
1.1 MB Download
Expected_download.mp4
727 KB Download

Comment 1 by dbeam@chromium.org, May 3 2016

Cc: dbeam@chromium.org
Status: Started (was: Assigned)

Comment 2 by dbeam@chromium.org, May 3 2016

Labels: ReleaseBlock-Stable
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1c3c70c29cd7b1745417fe915d2e213ab987f4

commit cf1c3c70c29cd7b1745417fe915d2e213ab987f4
Author: tommycli <tommycli@chromium.org>
Date: Tue May 03 18:46:12 2016

WebUI: Update Downloads to fix bug introduced by JS lifecycle controls.

The patch that added JS lifecycle calls to MdDownloadsDOMHandler
broke search terms.

This patch fixes that bug and adds a test to catch regressions.

BUG= 608317 

Review-Url: https://codereview.chromium.org/1938983003
Cr-Commit-Position: refs/heads/master@{#391313}

[modify] https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h
[modify] https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc

Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on Windows 7 & MAC (10.11.4) for Google Chrome Canary Version - 52.0.2724.0 

Screen-recording is attached.

@yfulgaonkar: Could you please have a look at the attached video and let us know your observations.

Thank you.
608317.mp4
1.4 MB Download
Labels: -Needs-Feedback
With response to comment #4

Rechecked above issue on Windows 7 using canary build 52.0.2724.0 and it is working as intended.

Thank you.

Comment 6 by dbeam@chromium.org, May 4 2016

Status: Fixed (was: Started)

Sign in to add a comment