New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608313 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Non Regression : Browser crashes on closing sign in overlay after closing devtools for locked profile

Project Member Reported by sc00335...@techmahindra.com, May 2 2016

Issue description

Version: 52.0.2722.0 dev
OS: Ubuntu 12.04,14.04,windows

What steps will reproduce the problem?
(1) Sign in to user >> Create/Import supervised user >> Go to parent profile, click avatar icon and select exit and childlock
(2) Now open User manager and select locked profile so that sign in overlay appears >> Before overlay fully loads right click so that inspect option is seen in context menu 
(3) Select inspect so that devtools opens >> Now close devtools and try closing authentication dialog and observe.

Expected: Browser should not crash on closing authentication dialog after closing devtools.

Actual: Instead browser crash is seen.

Crash ids: 045200b200000000 , 6a183fac00000000

This is a non-regression issue seen from the introduction of online re-authentication for locked profile i.e from 46.0.2467.0  dev. 

Cr:https://chromium.googlesource.com/chromium/src/+log/46.0.2466.0..46.0.2467.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/1220843003 from changelog.

@rogerta: Please confirm the issue.
 
Actual_supervisedcrash.ogv
2.5 MB Download
Project Member

Comment 1 by sheriffbot@chromium.org, May 5 2016

Labels: Fracas
Users experienced this crash on the following builds:



If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 2 by sheriffbot@chromium.org, May 28 2016

Labels: M-51
Users experienced this crash on the following builds:

Win Beta 51.0.2704.63 -  0.80 CPM, 229 reports, 218 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-51 -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 2 2016

Labels: FoundIn-51
Users experienced this crash on the following builds:

Win Beta 51.0.2704.63 -  1.11 CPM, 1360 reports, 1220 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 6 2016

Labels: FoundIn-M-51
Users experienced this crash on the following builds:

Win Stable 51.0.2704.79 -  0.22 CPM, 1358 reports, 1256 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Owner: anthonyvd@chromium.org
Repro'ed on Version 52.0.2743.33 beta (64-bit) linux.  Not a likely scenario.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 16 2016

Labels: FoundIn-M-53
Users experienced this crash on the following builds:

Win Dev 53.0.2767.4 -  0.12 CPM, 6 reports, 6 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Issue 623633 has been merged into this issue.
Cc: anthonyvd@chromium.org
Owner: mahmadi@chromium.org
Assigning to Moe, who has been working on the User Manager.

Moe, I recently landed a change (https://codereview.chromium.org/2093563003) to disable the context menu on the sign in flow in the tab modal flow. Maybe a similar fix would be relevant here too.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 21 2016

Labels: FoundIn-M-52
Users experienced this crash on the following builds:

Win Stable 52.0.2743.82 -  1.27 CPM, 32 reports, 30 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 21 2016

Users experienced this crash on the following builds:

Win Stable 52.0.2743.82 -  1.27 CPM, 32 reports, 30 clients (signature [Assert] ProfileDestroyer::~ProfileDestroyer)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/181eb213602d7e36865b6cc9fcc3835c721ab994

commit 181eb213602d7e36865b6cc9fcc3835c721ab994
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Aug 02 20:40:53 2016

Disables the context menu in User Manager's reauth dialog.

This prevents user from inspecting the contents of the dialog which causes a crash.

This CL also removes the logic where the WebContentsObserver closes the dialog automatically when the final URL is reached. The reauth dialog is closed explicitly in InlineLoginHandler::HandleDialogClose(). That logic is not needed.

BUG= 608313 

Review-Url: https://codereview.chromium.org/2168953002
Cr-Commit-Position: refs/heads/master@{#409311}

[modify] https://crrev.com/181eb213602d7e36865b6cc9fcc3835c721ab994/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
[modify] https://crrev.com/181eb213602d7e36865b6cc9fcc3835c721ab994/chrome/browser/ui/user_manager.cc
[modify] https://crrev.com/181eb213602d7e36865b6cc9fcc3835c721ab994/chrome/browser/ui/user_manager.h
[modify] https://crrev.com/181eb213602d7e36865b6cc9fcc3835c721ab994/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/181eb213602d7e36865b6cc9fcc3835c721ab994/chrome/browser/ui/views/profiles/user_manager_view.h

Status: Fixed (was: Started)

Sign in to add a comment