New issue
Advanced search Search tips

Issue 608287 link

Starred by 2 users
Status: WontFix
Owner:
rmcilroy@chromium.org
Closed: Mar 2017
Cc:
mythria@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 595646



Sign in to add a comment

Ignition with eager compilation causes LayoutTest failures (need rebaseline)

Project Member Reported by yangguo@chromium.org, May 2 2016 
The test failure diff is this:

--- /usr/local/google/home/yangguo/hdd/chromium/src/out/Release/layout-test-results/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt
+++ /usr/local/google/home/yangguo/hdd/chromium/src/out/Release/layout-test-results/inspector/sources/debugger-frameworks/frameworks-jquery-actual.txt
@@ -47,7 +47,7 @@
 Call stack:
     0) onTestEvent1 (frameworks-jquery.html:24)
   * 1) dispatch (jquery-1.11.1.min.js:3)
-  * 2) r.handle (jquery-1.11.1.min.js:3)
+  * 2) m.event.add.r.handle (jquery-1.11.1.min.js:3)
   * 3) trigger (jquery-1.11.1.min.js:3)
   * 4)  (jquery-1.11.1.min.js:3)
   * 5) each (jquery-1.11.1.min.js:2)
@@ -59,7 +59,7 @@
 Call stack:
     0) onTestEvent2 (frameworks-jquery.html:29)
   * 1) dispatch (jquery-1.11.1.min.js:3)
-  * 2) r.handle (jquery-1.11.1.min.js:3)
+  * 2) m.event.add.r.handle (jquery-1.11.1.min.js:3)
   * 3) trigger (jquery-1.11.1.min.js:3)
   * 4)  (jquery-1.11.1.min.js:3)
   * 5) each (jquery-1.11.1.min.js:2)
@@ -72,7 +72,7 @@
 Call stack:
     0) onTestEvent3 (frameworks-jquery.html:34)
   * 1) dispatch (jquery-1.11.1.min.js:3)
-  * 2) r.handle (jquery-1.11.1.min.js:3)
+  * 2) m.event.add.r.handle (jquery-1.11.1.min.js:3)
   * 3) trigger (jquery-1.11.1.min.js:3)
   * 4)  (jquery-1.11.1.min.js:3)
   * 5) each (jquery-1.11.1.min.js:2)


The function name inferrer collects more when the compilation is eager, which is the default for ignition. In case of --no-ignition-eager, this test passes.

I think we should simply rebaseline this test when ignition launches.

Comment 1 by yangguo@chromium.org, May 2 2016 

These two tests also fail due to test eager compilation:

inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html

They fail with --ignition or --no-lazy, but pass with --ignition --no-ignition-eager.

Comment 2 by yangguo@chromium.org, May 2 2016

Summary: Ignition with eager compilation causes test failures (need rebaseline) (was: inspector/sources/debugger-frameworks/frameworks-jquery.html with ignition)

Comment 3 by yangguo@chromium.org, May 2 2016

Summary: Ignition with eager compilation causes LayoutTest failures (need rebaseline) (was: Ignition with eager compilation causes test failures (need rebaseline))

Comment 4 by rmcilroy@chromium.org, May 3 2016 

Thanks for looking into these. Yes I agree, these should just be rebaselined when we launch (assuming we are still doing full eager compilation at that point).

Comment 5 by rmcilroy@chromium.org, Mar 2 2017

Status: WontFix (was: Assigned)
Not applicable any longer since we won't do eager compilation.
►

Sign in to add a comment