New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608271 link

Starred by 3 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
tapted@chromium.org
█ ashej...@chromium.org
mac-bugs-priority@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Info bar appears chopped after toggling browser to fullscreen mode.

Reported by vku...@etouch.net, May 2 2016 
Chrome Version:52.0.2722.0 (Official Build)884d81a6495cd1138a77425df55d80030b768de1-refs/heads/master@{#390853} 32/64-bit.
OS:Mac OSX(10.10.5, 10.11.4)

Precondition: Login to browser with credentials which has multiple bookmarks saved.

What steps will reproduce the problem?
1.Launch chrome and enter about:inducebrowsercrashforrealz in omnibox such that browser crashes.
2.Reopen the browser such that information bars (for chrome didn't shut down & default broswer) appears.
3.Now click on fullscreen icon from top left and observe.

Actual: Info bar appears chopped after toggling browser to fullscreen mode.

Expected: Info bar should be diaplyed after toggling browser to fullscreen mode.

This is a regression issue broken in 'M51' and will soon update other info.

Comment 1 by vku...@etouch.net, May 2 2016

Labels: hasbisect
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good build: 51.0.2665.0 
Bad build:  51.0.2666.0 

CL:
https://chromium.googlesource.com/chromium/src/+log/51.0.2665.0..51.0.2666.0?pretty=fuller&n=10000
(Unable to narrow down the range since getting all good chromium builds via tool)

Suspecting: 378915 ?
Kindly help to re-assign, if your changes are not cause for this issue.

Note: Issue not seen on Windows & Linux OS.
Actual_Infobar.mov
2.1 MB Download
Expected_Infobar.mov
1.5 MB Download

Comment 2 by tapted@chromium.org, May 3 2016

Cc: tapted@chromium.org
Owner: spqc...@chromium.org
r378915 doesn't affect the Cocoa browser window.

This might be r378770

===
Modified the behavior of "Hide Toolbar in Full Screen"

Changed the string to "Always Show Toolbar in Full Screen" and
reversed the logic. Modified the behavior so that instead of changing
just the current window, toggling the menu item will update all of the
windows associated with active profile.

BUG= 588110 

Review URL: https://codereview.chromium.org/1737413002

Comment 3 by spqc...@chromium.org, May 4 2016 

I'm currently investigating this. Just to confirm, was your browser set to not "Always Show Toolbar in Full Screen"?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47279775a3f42b190afcb962c917a24beb12612b

commit 47279775a3f42b190afcb962c917a24beb12612b
Author: spqchan <spqchan@chromium.org>
Date: Fri Nov 11 23:10:24 2016

[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.

BUG=  662734 ,  608271 

Review-Url: https://codereview.chromium.org/2491343003
Cr-Commit-Position: refs/heads/master@{#431676}

[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h
[modify] https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Comment 5 by spqc...@chromium.org, Nov 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment