Regression: Favicons of fully loaded sites are not seen in chrome://history |
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2722.0 Safari/537.36 Steps to reproduce the problem: 1.Launch google chrome 2.Browse for any four sites (Ex: f1 for help,webstore, youtube) 3.Navigate to Chrome://history and observe for favicon images What is the expected behavior? Images of fully loaded sites should be seen in chrome://history What went wrong? Instead images are not seen in chrome://history. Did this work before? Yes Chrome version: 52.0.2722.0 Channel: dev OS Version: 52.0.2722.0 Flash Version: Shockwave Flash 22.0 r0 This is regression issue broken in M52
,
May 2 2016
CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/ba39333a41b90207da717dde0e5178541d10fe33..f9a87728113bccfac096b340f59a03f877327359 Suspecting https://codereview.chromium.org/1914073005 from changelog. @dpapad: Please help in re-assigning if it is not related to your change.
,
May 2 2016
Issue is also seen in windows. Good Build: 52.0.2718.0 dev Bad Build: 52.0.2719.0 dev
,
May 2 2016
Able to reproduce the issue on Mac 10.11.4 using chrome version 52.0.2722.0
,
May 2 2016
I'll take a look and update this thread.
,
May 2 2016
FYI, I have a fix for this regression, https://codereview.chromium.org/1938063002.
,
May 2 2016
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cf3369501c9d3fa1bceff174beab20c1555832f commit 1cf3369501c9d3fa1bceff174beab20c1555832f Author: dpapad <dpapad@chromium.org> Date: Tue May 03 01:39:15 2016 WebUI: Fix favicon URL regression. This was caused by https://codereview.chromium.org/1914073005, because it assumed that there are only two types of URLs, 'iconurl' and 'origin'. There are actually three, 'iconurl', 'origin' and '' (empty string). In order to preserve previous behavior. getFaviconImageSet() should not handle 'origin' URLs. BUG= 608263 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1938063002 Cr-Commit-Position: refs/heads/master@{#391151} [modify] https://crrev.com/1cf3369501c9d3fa1bceff174beab20c1555832f/chrome/test/data/webui/util_test.html [modify] https://crrev.com/1cf3369501c9d3fa1bceff174beab20c1555832f/ui/webui/resources/js/util.js
,
May 3 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sc00335...@techmahindra.com
, May 2 2016Components: -UI UI>Browser>History
Labels: -Type-Bug -Pri-2 -Via-Wizard ReleaseBlock-Stable Needs-Bisect M-52 Pri-1 Type-Bug-Regression