New issue
Advanced search Search tips

Issue 608258 link

Starred by 6 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Chrome][M50][Android 6.0] Crash when saving link to DRM contents

Reported by seiyon.p...@gmail.com, May 2 2016

Issue description

Example URL:
wap.lge.com

Steps to reproduce the problem:
1. Open Chrome > wap.lge.com > LG DRM > Comblined Delivery > Video > Interval (2min) > DM direct download
2. Touch and hold a file from the list
3. Touch "Save link" to download the file

What is the expected behavior?
User can download DRM file.

What went wrong?
Chrome crashes

Did this work before? Yes M46

Chrome version: 50.0.2661.89  Channel: stable
OS Version: 6.0
Flash Version: Shockwave Flash 21.0 r0

When touching a file from the list, it is successful to download the file.
But when touching "Save link" from popup, Chrome crashes.
 
Labels: Needs-Feedback
Thanks for logging issue, can you please let us know what device is that (phone name)?

It is reproducible on nexus devices.
Project Member

Comment 3 by sheriffbot@chromium.org, May 12 2016

Labels: -Needs-Feedback Needs-Review
Owner: krav...@chromium.org
Thank you for providing more feedback. Adding requester "kravula@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Gentle reminder
Components: UI>Browser>Downloads
Labels: -Needs-Review Needs-Feedback
Owner: ----
Could you make sure you have crash reporting enabled (settings->privacy->Usage and crash reports), reproduce the problem, check about:crashes to see if there's a recent crash id, and report that id here?  If we can get a crash report that'll move us much closer to figure out what's happening.

Status: Untriaged (was: Unconfirmed)

Comment 7 by seiyon.p...@lge.com, May 20 2016

I couldn't find the crash report setting you've asked.
Instead of crash id, I've loaded the log.

Chrome_Log.7z
2.9 MB Download
Cc: qin...@chromium.org
Thanks!! for providing the logs. we tried on nexus6 device
wap.lge.com -> we are getting please enter Auth code
Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e33c5d6978752f31ed6702e72e46fdf78cd5565

commit 4e33c5d6978752f31ed6702e72e46fdf78cd5565
Author: qinmin <qinmin@chromium.org>
Date: Wed May 25 00:28:51 2016

Fix a crash when download a DRM file through context menu

This is a regression introduced by
https://codereview.chromium.org/1717783002.
Previously we use URLUtil.guessFileName() to generate file names for
download.
However, to fix crbug/570750, we rely on the native code to pass the
file name.
However, drm download through context menu bypasses the native download
code.
As a result, we need to generate the file name in Java if it is null.
Since content disposition is null, this will not cause the same problem
as reported in crbug/570750.

BUG=608258

Review-Url: https://codereview.chromium.org/2013643002
Cr-Commit-Position: refs/heads/master@{#395750}

[modify] https://crrev.com/4e33c5d6978752f31ed6702e72e46fdf78cd5565/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

Thanks for your support.
Hopefully it'll be merged into upcoming stable version.
Labels: -Type-Bug -Needs-Feedback Merge-Request-51 M-51 Type-Bug-Regression
Owner: qin...@chromium.org
Status: Started (was: Untriaged)

Comment 12 by tin...@google.com, May 25 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
Labels: -M-51 -Merge-Review-51 Merge-Approved-52 M-52
We have no more beta releases for M51 and this isn't a super critical issue, so let's get this merged and fixed for M52 instead.
Project Member

Comment 14 by bugdroid1@chromium.org, May 26 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/421b2fbe002d915307cc547e86b6004bba0bf4a3

commit 421b2fbe002d915307cc547e86b6004bba0bf4a3
Author: Min Qin <qinmin@chromium.org>
Date: Thu May 26 18:36:10 2016

Fix a crash when download a DRM file through context menu

This is a regression introduced by
https://codereview.chromium.org/1717783002.
Previously we use URLUtil.guessFileName() to generate file names for
download.
However, to fix crbug/570750, we rely on the native code to pass the
file name.
However, drm download through context menu bypasses the native download
code.
As a result, we need to generate the file name in Java if it is null.
Since content disposition is null, this will not cause the same problem
as reported in crbug/570750.

TBR=tedchoc@chromium.org
BUG=608258

Review-Url: https://codereview.chromium.org/2013643002
Cr-Commit-Position: refs/heads/master@{#395750}
(cherry picked from commit 4e33c5d6978752f31ed6702e72e46fdf78cd5565)

Review URL: https://codereview.chromium.org/2016783002 .

Cr-Commit-Position: refs/branch-heads/2743@{#83}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/421b2fbe002d915307cc547e86b6004bba0bf4a3/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

You started fixing this bug over two years ago. Are you still working on it? 

Sign in to add a comment