Regression: Unnecessary close icon stay after text vanished from search field of dev tools.
Reported by
rk...@etouch.net,
May 2 2016
|
||||||
Issue descriptionChrome Version: 52.0.2721.0 Revision 142b98e4d3b296b478eb5e549edb3ab2797a5f52-refs/heads/master@{#390803 OS: Windows (7,8,10), Mac OSX(10.10.5, 10.11.4) ,Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open dev tools window and press Esc key. (2) Open Search section, type any word in search field and right click on text then select 'Cut' option. (3) observe the close icon at end of the field Unnecessary close icon stays even if text get vanished from search field. Close icon should not stay after text vanishes. This is a regression issue, broken in 'M-52', below is bisect info: Good Build: 52.0.2718.0 Bad Build: 52.0.2719.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/66bea1de4dbc4a18684655979360031c14ad97a9..f1afe5ba38f00c14f9982c8d0b3afd598865f411?pretty=fuller&n=100 Suspecting: r390177
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a0127a88b7b690147fc7035a59d3c1cdf667dd0 commit 8a0127a88b7b690147fc7035a59d3c1cdf667dd0 Author: luoe <luoe@chromium.org> Date: Tue May 03 16:43:23 2016 DevTools: properly update close icon in search field BUG= 608252 Review-Url: https://codereview.chromium.org/1943433002 Cr-Commit-Position: refs/heads/master@{#391265} [modify] https://crrev.com/8a0127a88b7b690147fc7035a59d3c1cdf667dd0/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
,
May 3 2016
Cuts and other input events should now trigger an update on the 'close' icon in the commit above ^. Please review if needed. I hadn't thought about cut operations when making the commit. Nice regression find! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by l...@chromium.org
, May 2 2016