peppy : chromeos_laptop change to instantiate Peppy with Elan touchpad not upstream |
||||||||
Issue descriptionI landed this patch in chromeos-3.8 back in 2014 to enable Peppys that were second sourced with Elan touchpads instead of Cypress. a2d26a2 CHROMIUM: Platform: x86 : chromeos_laptop - Add elan trackpad option for Peppy This works if you're using a chromeos-3.8 kernel, but this patch was never applied to later kernels and never rebased or checked to see if it could be upstreamed. As a result, folks trying to run an upstream kernel don't have a functional trackpad on some Peppys. I'll send the patch to olof for platform/chrome and backport to our chromeos-4.4 so our generic kernels will support elan peppys as well.
,
May 1 2016
,
May 3 2016
see also issue 50932
,
May 26 2016
Olof merged the two patches to chrome-platform/for-next. I'll pick them back to chromeos-4.4.
,
May 26 2016
New Changes: https://chromium-review.googlesource.com/347500 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Remove light sensor from ... https://chromium-review.googlesource.com/347501 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Remove light sensor from ... https://chromium-review.googlesource.com/347502 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Add Leon Touch" https://chromium-review.googlesource.com/347503 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Add Wolf touch + light ... https://chromium-review.googlesource.com/347504 UPSTREAM: platform/chrome: chromeos_laptop - Add elan trackpad option for C720 https://chromium-review.googlesource.com/347505 UPSTREAM: platform/chrome: chromeos_laptop - Add Elan touchpad for Wolf I also too the liberty of cleaning up some duplicate entries that crept into the chromeos_laptop driver during the rebase effort.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a589f0371df823a70dfd444ecb5d91cb947107e2 commit a589f0371df823a70dfd444ecb5d91cb947107e2 Author: Charlie Mooney <charliemooney@chromium.org> Date: Mon May 02 00:57:17 2016 UPSTREAM: platform/chrome: chromeos_laptop - Add Elan touchpad for Wolf The upcoming Elan Wolf (Dell Chromebook 11) devices need to know to look for Elan touchpads on the i2c bus so that they will be functional. Based on the chromeos-kernel commit : https://chromium-review.googlesource.com/198283 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Olof Johansson <olof@lixom.net> (cherry picked from commit 9e96aa70e9acd03eee61c2094b4755b80a386c47) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:608176 TEST=build and boot amd64-generic kernel on elan variant Dell 11 (wolf). Check that touchpad works. Change-Id: Id5950986a258f840eaebd5b44d67ee1dd90101c4 Reviewed-on: https://chromium-review.googlesource.com/347505 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/a589f0371df823a70dfd444ecb5d91cb947107e2/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/132bb1c4e32a04b7aa11ac16d897b99c5541411f commit 132bb1c4e32a04b7aa11ac16d897b99c5541411f Author: Benson Leung <bleung@chromium.org> Date: Mon May 02 00:57:16 2016 UPSTREAM: platform/chrome: chromeos_laptop - Add elan trackpad option for C720 Add the elan trackpad to the Acer C720 (peppy) list, as it is an alternate trackpad option. It may exist at i2c address 0x15. Based on this change from the chromeos kernel : https://chromium-review.googlesource.com/186253 Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Olof Johansson <olof@lixom.net> (cherry picked from commit 9bd9a90b013c647ed88ed4fa69b664b770924cf0) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:608176 TEST=build and boot amd64-generic kernel on elan variant Acer C720 (peppy). Check that touchpad works. Change-Id: I7873d3be941055cfdaad4fa75eab63373da2f849 Reviewed-on: https://chromium-review.googlesource.com/347504 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/132bb1c4e32a04b7aa11ac16d897b99c5541411f/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/59911980026ca9eb4ad2a47cf45a5868f8693682 commit 59911980026ca9eb4ad2a47cf45a5868f8693682 Author: Benson Leung <bleung@chromium.org> Date: Thu May 26 01:19:57 2016 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Add Leon Touch" This reverts commit 4d226583563a9ae93f9e058fa391c317ba80c847. These commits brought over during the 3.18 -> 4.4 rebase introduce duplicate entries for Wolf and Leon. Remove them. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= 608176 TEST=build and boot amd64-generic kernel on Leon. Check that touchpad works. Change-Id: Id3db1bfaee2eab6ecf5da2aea68e0e7a39d65fc8 Reviewed-on: https://chromium-review.googlesource.com/347502 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/59911980026ca9eb4ad2a47cf45a5868f8693682/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c995f0c892d55b6b07903186ec0de54aed206101 commit c995f0c892d55b6b07903186ec0de54aed206101 Author: Benson Leung <bleung@chromium.org> Date: Thu May 26 01:20:01 2016 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Add Wolf touch + light sensor" This reverts commit 2bb11d27a264c18031030b5e2b62608135e62279. These commits brought over during the 3.18 -> 4.4 rebase introduce duplicate entries for Wolf and Leon. Remove them. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= 608176 TEST=build and boot amd64-generic kernel on Wolf. Check that touchpad works. Change-Id: I636060bb18f8f06d92b8d76adfac37e999aab214 Reviewed-on: https://chromium-review.googlesource.com/347503 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/c995f0c892d55b6b07903186ec0de54aed206101/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/dfdf7b9bad192cb32c94169bf4659db9094f1bc1 commit dfdf7b9bad192cb32c94169bf4659db9094f1bc1 Author: Benson Leung <bleung@chromium.org> Date: Thu May 26 01:19:12 2016 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Remove light sensor from Leon" This reverts commit f1609504bd550eb238f1858fb714509231d73db8. These commits brought over during the 3.18 -> 4.4 rebase introduce duplicate entries for Wolf and Leon. Remove them. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= 608176 TEST=build and boot amd64-generic kernel on Leon. Check that touchpad works. Change-Id: If8c97535891157ddd3994a8e643893869ab8429a Reviewed-on: https://chromium-review.googlesource.com/347501 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/dfdf7b9bad192cb32c94169bf4659db9094f1bc1/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/122c52d1eea628f6ab31b815c95d25479e6d0974 commit 122c52d1eea628f6ab31b815c95d25479e6d0974 Author: Benson Leung <bleung@chromium.org> Date: Thu May 26 01:19:08 2016 Revert "CHROMIUM: Platform: x86: chromeos_laptop - Remove light sensor from wolf." This reverts commit dd3e408e760aa31c8a54c599c9f7b96487ed34ac. These commits brought over during the 3.18 -> 4.4 rebase introduce duplicate entries for Wolf and Leon. Remove them. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= 608176 TEST=build and boot amd64-generic kernel on Wolf. Check that touchpad works. Change-Id: I14b73186d73c44a56f9dc629f85ea8a40b28737d Reviewed-on: https://chromium-review.googlesource.com/347500 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/122c52d1eea628f6ab31b815c95d25479e6d0974/drivers/platform/chrome/chromeos_laptop.c
,
May 26 2016
,
Jul 1 2016
,
Aug 29 2016
,
Aug 31 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bleung@chromium.org
, May 1 2016