[Mac][Material Design] New Omnibox Dropdown Text alignment issue |
|||
Issue descriptionVersion: 52.0.2721.0 canary (64-bit) OS: OS X 10.11.4 What steps will reproduce the problem? (1) type something into the Omnibox (2) compare the vertical alignment of the Omnibox text with the Dropdown text What is the expected output? What do you see instead? After issue 596684 was fixed, we now have one additional pt of space between the icon and the text in the Omnibox. This has an effect on the Dropdown, so that the text there also need +1pt space to be aligned. Please use labels and text to provide additional information. A screenshot is attached. Thanks and regards Mehmet
,
May 10 2016
,
May 13 2016
Just to clarify, I just need to add 1pt between the icon and the text in the Omnibox, but in order to prevent regressing Issue 596684 , I will also need to make sure that the additional 2px between the search chip and text remains?
,
May 13 2016
You just need to add the 1pt in the Omnibox. The design of the search and ev chips is changing so don't worry about trying to keep things aligned there.
,
May 13 2016
Awesome, thanks for the clarification
,
May 13 2016
Yes, I meant to add +1pt between the icon and the text in the Dropdown, so that the text in the Dropdown is vertically aligned with the text in the Omnibox (Addressbar). Thanks a lot :-)
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/523930966431748fbe2bee1ebcb90c882a1db38a commit 523930966431748fbe2bee1ebcb90c882a1db38a Author: spqchan <spqchan@chromium.org> Date: Fri May 13 22:53:30 2016 [Mac][Material] Add 1pt to the text in the Omnibox dropdown BUG= 608148 Review-Url: https://codereview.chromium.org/1977013003 Cr-Commit-Position: refs/heads/master@{#393666} [modify] https://crrev.com/523930966431748fbe2bee1ebcb90c882a1db38a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
,
May 13 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, May 6 2016